migrate auth tests to common #7 #15578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
auth_test_split_7
branch
from
88d7cd1
to
9a2553f
Compare
ptabor
reviewed
Mar 28, 2023
| err = rootAuthClient.Put(ctx, "key", "value", config.PutOptions{LeaseID: lresp.ID}) | ||
| require.NoError(t, err) | ||
|
|
||
| _, err = rootAuthClient.Revoke(ctx, lresp.ID) |
There was a problem hiding this comment.
If we have a test targeting this method specifically, it would be good to assert what's returning actually.
[I know that it was not tested previously... ]
There was a problem hiding this comment.
clientv3 Lease revoke response is the type alias of the proto buf generated one. It only contains ResponseHeader.
type LeaseRevokeResponse struct {
Header *ResponseHeader `protobuf:"bytes,1,opt,name=header,proto3" json:"header,omitempty"`
XXX_NoUnkeyedLiteral struct{} `json:"-"`
XXX_unrecognized []byte `json:"-"`
XXX_sizecache int32 `json:"-"`
}
I was blindly migrate the old logic to this one. How about assert the revoked lease is no longer in LeaseList response and get response is empty?
ptabor
reviewed
Mar 28, 2023
| cc := testutils.MustClient(clus.Client()) | ||
| testutils.ExecuteUntil(ctx, t, func() { | ||
| require.NoErrorf(t, setupAuth(cc, []authRole{testRole}, []authUser{rootUser, testUser}), "failed to enable auth") | ||
| rootAuthClient := testutils.MustClient(clus.Client(WithAuth(rootUserName, rootPassword))) |
There was a problem hiding this comment.
Logically this are 2 subtests, so ideally we should run them in tested t.run(...).
There was a problem hiding this comment.
Could you please point to which 2 tests? I guess root and test user, respectively?
ptabor
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the ask from #14041 to split tests into smaller pieces.
So code review will be reviewer friendly and easier to reason about.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.