add livez readyz e2e tests #16835
Merged
add livez readyz e2e tests #16835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaochn47
force-pushed
the
e2e-livez-readyz
branch
from
7c9ded2
to
15ae6f0
Compare
serathius
reviewed
Oct 27, 2023
serathius
reviewed
Oct 27, 2023
serathius
reviewed
Oct 27, 2023
serathius
reviewed
Oct 27, 2023
chaochn47
force-pushed
the
e2e-livez-readyz
branch
from
15ae6f0
to
d1124f9
Compare
|
Thanks for the review! Could you please take a second look? @serathius |
serathius
reviewed
Oct 28, 2023
serathius
approved these changes
Oct 28, 2023
Signed-off-by: Chao Chen <chaochn@amazon.com>
Signed-off-by: Chao Chen <chaochn@amazon.com>
chaochn47
force-pushed
the
e2e-livez-readyz
branch
from
d1124f9
to
42d9e43
Compare
ahrtr
approved these changes
Oct 29, 2023
Comment on lines
+392
to
+408
| time.Sleep(time.Second) | ||
| select { | ||
| case <-ctx.Done(): | ||
| require.NoError(t, err) | ||
| default: | ||
| } | ||
| response, err := etcdctl.AlarmList(ctx) | ||
| if err != nil { | ||
| continue | ||
| } | ||
| if len(response.Alarms) == 0 { | ||
| continue | ||
| } | ||
| require.Len(t, response.Alarms, 1) | ||
| if response.Alarms[0].Alarm == etcdserverpb.AlarmType_CORRUPT { | ||
| break | ||
| } |
There was a problem hiding this comment.
Nit: should we have a timeout for this indefinite for loop, and fail the test when timedout?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #16784 since its CI test failed.
Based on #16792 (comment), this test should be merged first and #16792 will be rebased on top of it.
@siyuanfoundation on the second commit.
/cc @serathius
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.