Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changelog: add 3.4 and 3.5 note about go 1.20.13 #17309

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Jan 23, 2024

Updates 3.4 and 3.5 CHANGELOGs to add a line that the binaries are compiled with go version 1.20.13.

Related to #17269

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@k8s-ci-robot
Copy link

Hi @ivanvc. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for completing the upgrade @ivanvc - just a small tweak needed for 3.5 changelog then this will be good to merge.

@@ -16,7 +16,7 @@ Previous change logs can be found at [CHANGELOG-3.4](https://github.com/etcd-io/
- Fix [url redirects while checking peer urls during new member addition](https://github.com/etcd-io/etcd/pull/16986)

### Dependencies
- Compile binaries using [go 1.20.12](https://github.com/etcd-io/etcd/pull/17077)
- Compile binaries using [go 1.20.13](https://github.com/etcd-io/etcd/pull/17275)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.5.11 has already been released so we need to leave this line as is and make a new entry for ### Dependencies under 3.5.12.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think we need separate lines each dependency update, at least historically we only kept the latest update of one kind.

Signed-off-by: Ivan Valdes <ivan@vald.es>
@ivanvc ivanvc force-pushed the update-changelog-to-add-go-1.20.13 branch from 606191a to c83feeb Compare January 25, 2024 19:51
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Thanks

@serathius serathius merged commit 58846bd into etcd-io:main Jan 26, 2024
40 checks passed
@ivanvc ivanvc deleted the update-changelog-to-add-go-1.20.13 branch February 1, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

5 participants