Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go 1.21.10 and 1.22.3 #17964

Closed
ahrtr opened this issue May 7, 2024 · 18 comments
Closed

Bump go 1.21.10 and 1.22.3 #17964

ahrtr opened this issue May 7, 2024 · 18 comments

Comments

@ahrtr
Copy link
Member

ahrtr commented May 7, 2024

What would you like to be added?

Both 1.21.10 and 1.22.3 include security fixes

Why is this needed?

fix CVE

@ivanvc
Copy link
Member

ivanvc commented May 7, 2024

Completion tracking below:

Refer to previous PRs as a reference, i.e., #17269

@ivanvc
Copy link
Member

ivanvc commented May 7, 2024

@ahrtr, do we want to update bbolt and raft? Based on recent conversations I'm unsure if that's the intention.

@lavishpal
Copy link
Contributor

@ahrtr could you assign this issue to me ?

@ivanvc
Copy link
Member

ivanvc commented May 7, 2024

/assign @lavishpal

@ahrtr
Copy link
Member Author

ahrtr commented May 8, 2024

@ahrtr, do we want to update bbolt and raft? Based on recent conversations I'm unsure if that's the intention.

I think the answer is YES. We follow the same rule as documented in dependency_management.md#golang-versions for all repos, and also #17876

@ahrtr
Copy link
Member Author

ahrtr commented May 9, 2024

Can we submit the PRs of bumping golang version for etcd (including main, release-3.5 and release-3.4) this week? Otherwise we will keep seeing failed workflow checks.

We also need to release new patches for 3.5 and 3.4 soon.

@henrybear327
Copy link
Contributor

Can we submit the PRs of bumping golang version for etcd (including main, release-3.5 and release-3.4) this week? Otherwise we will keep seeing failed workflow checks.

We also need to release new patches for 3.5 and 3.4 soon.

It would be nice to have it done ASAP since this is blocking #17973 as the CI will not pass (and we would not like this to spillover to next week).

@ahrtr Maybe I can take over the etcd main branch update so I can proceed with the dependency update normally, while in the meantime @lavishpal can take his/her time working on the rest of the branches? :)

@ivanvc
Copy link
Member

ivanvc commented May 9, 2024

Ping @lavishpal. Would you work on this this week? Otherwise, we may need to reassign to some collaborator who can help with it, as it is making it fail our CI jobs. Thanks.

@lavishpal
Copy link
Contributor

I will complete this within 2 days .

@jmhbnz
Copy link
Member

jmhbnz commented May 10, 2024

Hey @lavishpal - Do you have capacity to complete the remainder of the pull requests listed in the completion tracker above #17964 (comment)?

@lavishpal
Copy link
Contributor

Hey @lavishpal - Do you have capacity to complete the remainder of the pull requests listed in the completion tracker above #17964 (comment)?

Yeah i will complete it by tomorrow.

@ivanvc
Copy link
Member

ivanvc commented May 10, 2024

Wow, that was very quick. Thanks for the PRs, @lavishpal. Please update the ' CHANGELOG ' after closing #17980 and #17981.

Thanks again.

@ivanvc
Copy link
Member

ivanvc commented May 10, 2024

Also, as reference 1.21.10/1.22.3 address CVE: CVE-2024-24787.

@ivanvc
Copy link
Member

ivanvc commented May 12, 2024

@lavishpal, do you have the capacity to update the CHANGELOGs? As a reference, this is the PR when we updated them to 1.20.13: #17309

Thanks

@lavishpal
Copy link
Contributor

@lavishpal, do you have the capacity to update the CHANGELOGs? As a reference, this is the PR when we updated them to 1.20.13: #17309

Thanks

@ivanvc Sure i will finish it by tomorrow.

@ahrtr
Copy link
Member Author

ahrtr commented May 14, 2024

I think we are ready to release new patches for both 3.4 and 3.5. @jmhbnz @spzala

@jmhbnz
Copy link
Member

jmhbnz commented May 15, 2024

I think we are ready to release new patches for both 3.4 and 3.5. @jmhbnz @spzala

Agree. I've opened the planning issues:

I am happy to be release lead for v3.5.14, @spzala do you have availability to lead v3.4.33 release?

@ivanvc
Copy link
Member

ivanvc commented May 17, 2024

With all the tasks completed, we can close this issue now. Thanks, @lavishpal, for helping with this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

5 participants