Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2024-05-20] Bump dependency updates identified by dependabot #18045

Merged
merged 3 commits into from
May 21, 2024

Conversation

henrybear327
Copy link
Contributor

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.

Summary of actions

Reference:
- etcd-io#18040

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
…1 to 2.20.0

Reference:
- etcd-io#18035

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@k8s-ci-robot
Copy link

Hi @henrybear327. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Reference:
- etcd-io#18034

Signed-off-by: Chun-Hung Tseng <henrybear327@gmail.com>
@ivanvc
Copy link
Member

ivanvc commented May 21, 2024

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @henrybear327.

@ahrtr
Copy link
Member

ahrtr commented May 21, 2024

Thanks for the PR.

I see there are some changes in *.pb.gw.go files, are they automatic or manual changes?

@henrybear327
Copy link
Contributor Author

Thanks for the PR.

I see there are some changes in *.pb.gw.go files, are they automatic or manual changes?

Sorry for not being clear.

Static analysis CI check failed, so I ran scripts/genproto.sh to fix it, and squashed the commit into the bump gRPC commit.

Should I split the commit or do some other checking? :)

@ahrtr
Copy link
Member

ahrtr commented May 21, 2024

Static analysis CI check failed, so I ran scripts/genproto.sh to fix it,

Thanks for the clarification. Looks good.

@ahrtr ahrtr merged commit 1714b25 into etcd-io:main May 21, 2024
45 checks passed
@henrybear327 henrybear327 deleted the dependency_update/5_20_24 branch May 21, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

4 participants