Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: add etcdctlv3 for etcdctlv3 e2e test #4332

Closed
wants to merge 1 commit into from

Conversation

gyuho
Copy link
Contributor

@gyuho gyuho commented Jan 29, 2016

/cc @jonboulle @xiang90 @heyitsanthony

Can we also build etcdctlv3? We need it to test v3 features in e2e.

@xiang90
Copy link
Contributor

xiang90 commented Jan 29, 2016

we should not build etcdctlv3 for now. I am not sure how to make it happen. Ideally we should only build one ctl tool that works with both v2 and v3.

@gyuho
Copy link
Contributor Author

gyuho commented Jan 29, 2016

@xiang90 Got it. Maybe when we release v3, we can ship integrated ctl. Thanks

@gyuho gyuho closed this Jan 29, 2016
@gyuho gyuho deleted the build_etcdctlv3 branch January 29, 2016 00:33
@xiang90
Copy link
Contributor

xiang90 commented Jan 29, 2016

@gyuho If you want to write some tests, probably we should write test for clientv3 first. You can start with integration test under clientv3. Basically setup a real cluster and then use client library to interact with it.

@gyuho
Copy link
Contributor Author

gyuho commented Jan 29, 2016

Ok that sounds better. Will take a look. Thanks.

@jonboulle
Copy link
Contributor

do we need to start designing a UX for a tool that would talk to both?

On Fri, Jan 29, 2016 at 1:29 AM, Xiang Li notifications@github.com wrote:

we should not build etcdctlv3 for now. I am not sure how to make it
happen. Ideally we should only build one ctl tool that works with both v2
and v3.


Reply to this email directly or view it on GitHub
#4332 (comment).

@xiang90
Copy link
Contributor

xiang90 commented Feb 3, 2016

@jonboulle I have been discussing this with @gyuho. We plan to come up with something next week or the week after next week. We are busy working on the clientv3 and setup testing environment for v3 cluster this week.

@jonboulle
Copy link
Contributor

cool, thanks for the update!

On Wed, Feb 3, 2016 at 8:09 AM, Xiang Li notifications@github.com wrote:

@jonboulle https://github.com/jonboulle I have been discussing this
with @gyuho https://github.com/gyuho. We plan to come up with something
next week or the week after next week. We are busy working on the clientv3
and setup testing environment for v3 cluster this week.


Reply to this email directly or view it on GitHub
#4332 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants