mvcc: restore into tree index with one key index #8127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will this fix #8048? |
heyitsanthony
force-pushed
the
fix-restore
branch
from
5eff571
to
2d2af1d
Compare
|
@xiang90 yes, appears to be fixed; could repro on master, can't repro with the patch |
heyitsanthony
force-pushed
the
fix-restore
branch
3 times, most recently
from
d939914
to
39fad19
Compare
|
/cc @fanminshi |
gyuho
reviewed
Jun 19, 2017
mvcc/kvstore.go
Outdated
| kiCache := make(map[string]*keyIndex, restoreChunkKeys) | ||
| for rkv := range rkvc { | ||
| ki, ok := kiCache[rkv.kstr] | ||
| // purge cache if too many keys and missing |
There was a problem hiding this comment.
s/many keys and/many keys are/?
There was a problem hiding this comment.
missing as in rkv.kstr is missing, but can clarify
Clobbering the mvcc kvindex with new keyIndexes for each restore chunk would cause index corruption by dropping historical information.
heyitsanthony
force-pushed
the
fix-restore
branch
from
39fad19
to
51a568a
Compare
gyuho
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clobbering the mvcc kvindex with new keyIndexes for each restore
chunk would cause index corruption by dropping historical information.