etcdctl: fix snapshot status accidentally modified the db file #8815
Conversation
zrss
force-pushed
the
fix-dbstatus-unexpected-write
branch
from
cfc2703
to
29ec881
Compare
zrss
changed the title
zrss
force-pushed
the
fix-dbstatus-unexpected-write
branch
from
29ec881
to
4a2c9f7
Compare
|
lgtm. @zrss i am curious about how did you find this out? |
| @@ -409,7 +409,7 @@ func dbStatus(p string) dbstatus { | |||
|
|
|||
| ds := dbstatus{} | |||
|
|
|||
| db, err := bolt.Open(p, 0400, nil) | |||
| db, err := bolt.Open(p, 0400, &bolt.Options{NoFreelistSync: true}) | |||
zrss
force-pushed
the
fix-dbstatus-unexpected-write
branch
from
4a2c9f7
to
c20151f
Compare
|
@xiang90 er, i just wanna to check the count of keys in db file through |
|
@heyitsanthony fix |
|
@gyuho no need to backport this to 3.2. we never enabled nosyncfreelist in 3.2. |
| @@ -409,7 +409,7 @@ func dbStatus(p string) dbstatus { | |||
|
|
|||
| ds := dbstatus{} | |||
|
|
|||
| db, err := bolt.Open(p, 0400, nil) | |||
| db, err := bolt.Open(p, 0400, &bolt.Options{ReadOnly: true}) | |||
There was a problem hiding this comment.
we still need the nofsync option. also the file is already opened as readonly (0400), it is strange that we write it somehow...
can you also add an e2e test for the case that you described to prevent any potential regression?
There was a problem hiding this comment.
oh. i looked at the open code in boltdb, it does not try to interpret the fileperm bit anyway...
There was a problem hiding this comment.
only ReadOnly is OK; bbolt will detect if there's a free list or not, which is why it was rebuilding the free list here
There was a problem hiding this comment.
er, i will add a e2e test for the integrity verification with ReadOnly Option soon
There was a problem hiding this comment.
it seems there is no test case for etcdctl ... should i add a new test file for snapshot_command or somewhere else ?
There was a problem hiding this comment.
zrss
force-pushed
the
fix-dbstatus-unexpected-write
branch
from
c20151f
to
1010611
Compare
zrss
force-pushed
the
fix-dbstatus-unexpected-write
branch
from
1010611
to
0ce02ab
Compare
|
LGTM |
etcdctl: snapshot status open bbolt with ReadOnly as true
this can avoid writing the freelist to the db file