auth: a new auth token provider nop #9369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyuho
approved these changes
Feb 27, 2018
auth/nop.go
Outdated
|
|
||
| func newTokenProviderNop() (*tokenNop, error) { | ||
| return &tokenNop{}, nil | ||
|
|
There was a problem hiding this comment.
Remove extraneous white lines at 33 and 36?
This commit adds a new auth token provider named nop. The nop provider refuses every Authenticate() request so CN based authentication can only be allowed. If the tokenOpts parameter of auth.NewTokenProvider() is empty, the provider will be used.
mitake
force-pushed
the
nop-auth-token
branch
from
9913073
to
8eb7cfb
Compare
Codecov Report
@@ Coverage Diff @@
## master #9369 +/- ##
=========================================
Coverage ? 72.63%
=========================================
Files ? 362
Lines ? 30729
Branches ? 0
=========================================
Hits ? 22320
Misses ? 6794
Partials ? 1615
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds a new auth token provider named nop. The nop provider
refuses every Authenticate() request so CN based authentication can
only be allowed. If the tokenOpts parameter of auth.NewTokenProvider()
is empty, the provider will be used.
Fix #9349
/cc @stts @gyuho