Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vendor: update "grpc-gateway" to v1.4.1 #9757

Merged
merged 3 commits into from May 23, 2018
Merged

Conversation

hexfusion
Copy link
Contributor

@hexfusion hexfusion commented May 23, 2018

This was cut last night and I would like to keep on lastest if possible. grpc-ecosystem/grpc-gateway#658 which was added to this release will allow us to consolidate our 3 swagger JSON specs into 1. I think this will be much more user-friendly for folks looking to use the spec to generate code.

@codecov-io
Copy link

Codecov Report

Merging #9757 into master will increase coverage by 1.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9757      +/-   ##
==========================================
+ Coverage   68.64%   69.67%   +1.03%     
==========================================
  Files         374      375       +1     
  Lines       35129    35179      +50     
==========================================
+ Hits        24114    24512     +398     
+ Misses       9242     8911     -331     
+ Partials     1773     1756      -17
Impacted Files Coverage Δ
proxy/grpcproxy/register.go 69.44% <0%> (-13.89%) ⬇️
etcdctl/ctlv3/command/printer_simple.go 72.48% <0%> (-1.35%) ⬇️
clientv3/balancer/grpc1.7-health.go 85.17% <0%> (-1.17%) ⬇️
etcdserver/v3_server.go 75.11% <0%> (-0.96%) ⬇️
etcdserver/api/rafthttp/stream.go 78.96% <0%> (-0.86%) ⬇️
raft/raft.go 90.99% <0%> (-0.7%) ⬇️
pkg/proxy/server.go 60.2% <0%> (-0.68%) ⬇️
mvcc/watchable_store.go 82.74% <0%> (-0.36%) ⬇️
etcdserver/api/v3rpc/watch.go 77.44% <0%> (-0.34%) ⬇️
integration/cluster_proxy.go 100% <0%> (ø)
... and 34 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20b1a98...f31a02d. Read the comment docs.

Copy link
Contributor

@gyuho gyuho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks!

@gyuho gyuho merged commit 0e2dd3e into etcd-io:master May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants