Implement failpoint counter #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ramil Mirhasanov <ramil600@yahoo.com> Signed-off-by: Prasad Chandrasekaran <prasadc@vmware.com> Co-authored-by: Marek Siarkowicz <marek.siarkowicz@protonmail.com> Co-authored-by: Benjamin Wang <wachao@vmware.com>
serathius
reviewed
Nov 9, 2023
runtime/http.go
Outdated
| lines[i] = fps[i] + "=" + s | ||
| } | ||
| w.Write([]byte(strings.Join(lines, "\n") + "\n")) | ||
| } else if strings.HasSuffix(key, "/execution-count") { |
There was a problem hiding this comment.
Don't think the change from "/count" to "/execution-count" was needed.
There was a problem hiding this comment.
Recovered to "/count"
serathius
approved these changes
Nov 9, 2023
|
Please fix the failures |
ZhouJianMS
force-pushed
the
failpoint-counter-v3
branch
from
dc10eb8
to
e2975e9
Compare
lint failures fixed, please review |
serathius
reviewed
Nov 11, 2023
serathius
reviewed
Nov 11, 2023
serathius
reviewed
Nov 11, 2023
ZhouJianMS
force-pushed
the
failpoint-counter-v3
branch
from
e2975e9
to
e8dcc53
Compare
|
cc @ahrtr |
ahrtr
reviewed
Nov 11, 2023
doc/design.md
Outdated
| @@ -69,6 +69,16 @@ Similarly, you can set multiple failpoints using endpoint `/failpoints`, | |||
| curl http://127.0.0.1:22381/failpoints -X PUT -d'failpoint1=return("hello");failpoint2=sleep(10)' | |||
| ``` | |||
|
|
|||
| You can get the execution count of the failpoint in the dynamic way, | |||
There was a problem hiding this comment.
nit
Suggested change
| You can get the execution count of the failpoint in the dynamic way, | |
| You can get the execution count of a failpoint in the dynamic way, |
runtime/terms_test.go
Outdated
Comment on lines
84
to
88
| // This example tests mods which allows users to restrict the | ||
| // number of failpoint actions as against their callsite executions. | ||
| // This is the reason why wantCount < runAfterEnabling | ||
| // In a real world example you can hit a code spot a million times but | ||
| // using mods restrict the associated fallpoint actions to run twice. |
There was a problem hiding this comment.
It's a good test case, but the comment isn't clear to me.
Suggested change
| // This example tests mods which allows users to restrict the | |
| // number of failpoint actions as against their callsite executions. | |
| // This is the reason why wantCount < runAfterEnabling | |
| // In a real world example you can hit a code spot a million times but | |
| // using mods restrict the associated fallpoint actions to run twice. | |
| // Note the chain of terms is allowed to be executed 11 times at most, | |
| // including 10 times for the first term `10*sleep(10)` and 1 time for | |
| // the second term `1*return("abc")`. So it's only evaluated 11 times | |
| // even it's triggered 12 times. |
There was a problem hiding this comment.
Done. Thanks for your suggestions!
jmhbnz
approved these changes
Nov 11, 2023
There was a problem hiding this comment.
Great work @ZhouJianMS. Looks good, one minor suggestion below.
jmhbnz
reviewed
Nov 11, 2023
runtime/http.go
Outdated
| fp := key[:len(key)-len("/count")] | ||
| _, count, err := status(fp) | ||
| if err != nil { | ||
| if err == ErrNoExist { |
There was a problem hiding this comment.
Nit - Suggest errors.Is.
Suggested change
| if err == ErrNoExist { | |
| if errors.Is(err, io.ErrNoExist) { |
There was a problem hiding this comment.
Done. Thanks for your suggestion!
Signed-off-by: ZhouJianMS <zhoujian@microsoft.com>
ZhouJianMS
force-pushed
the
failpoint-counter-v3
branch
from
e8dcc53
to
88b6b0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR based out of @ramil600 PR #37 and @pchan PR #47 and is intended to address etcd-io/etcd#14729.
New changes include:
cc: @ramil600 @pchan @serathius @ahrtr @lavacat