tests: add helpers for generating entry slices #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serathius PTAL. This is just a mechanical clean-up in tests. |
serathius
reviewed
Jan 31, 2024
pav-kv
force-pushed
the
entry-slice-helper
branch
from
0529b9e
to
f425f2b
Compare
pav-kv
commented
Feb 2, 2024
pav-kv
force-pushed
the
entry-slice-helper
branch
from
f425f2b
to
46b968a
Compare
pav-kv
force-pushed
the
entry-slice-helper
branch
2 times, most recently
from
856c869
to
e1507e6
Compare
pav-kv
commented
Feb 3, 2024
There was a problem hiding this comment.
@serathius I converted a few more test files.
Once happy, please merge. Thank you.
| {[]pb.Entry{{Term: 1, Index: 1}, {Term: 1, Index: 2}}, 2, 1, false}, | ||
| // voter higher logterm | ||
| {[]pb.Entry{{Term: 2, Index: 1}}, 1, 1, true}, | ||
| {[]pb.Entry{{Term: 2, Index: 1}}, 1, 2, true}, | ||
| {[]pb.Entry{{Term: 2, Index: 1}, {Term: 1, Index: 2}}, 1, 1, true}, |
There was a problem hiding this comment.
This line was incorrect: terms in a log can not regress. Added two correct tests instead.
Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
pav-kv
force-pushed
the
entry-slice-helper
branch
from
e1507e6
to
8bc20e9
Compare
serathius
approved these changes
Feb 6, 2024
ahrtr
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #146