log: fixup raftLog initialization #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pav-kv
commented
Feb 1, 2024
|
Hi @serathius. Could you please merge this and #147? These are pretty trivial test-only clean-ups, but I have other useful work on top of them and would like to avoid the trouble of maintaining these branches or duplicating these cleanups across PRs. |
|
Please rebase this PR. |
Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
Signed-off-by: Pavel Kalinnikov <pavel@cockroachlabs.com>
|
@ahrtr done |
ahrtr
approved these changes
Feb 6, 2024
There was a problem hiding this comment.
lgtm
Most change are mechanical changes. cc @erikgrinaker to take a second look
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the
raftLogstruct initialization into a single return statement. It also makes all unit-tests use thenewLogconstructor function to initialize a log, instead of populating the struct manually.Changes to the
unstable/raftLogstructures should by default not require fixing boilerplate in tests.Related to #146
Blocks #139