Update faq.md #104
Closed
Update faq.md #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just updating [backup] and [runtime reconfiguration] links
| @@ -152,9 +152,9 @@ etcd sends a snapshot of its complete key-value store to refresh slow followers | |||
| [new_issue]: https://github.com/etcd-io/etcd/issues/new | |||
| [backend_commit_metrics]: ./metrics.md#disk | |||
| [raft]: https://raft.github.io/raft.pdf | |||
| [backup]: https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/recovery.md#snapshotting-the-keyspace | |||
| [backup]: https://github.com/etcd-io/website/blob/master/content/docs/v3.4.0/op-guide/recovery.md#snapshotting-the-keyspace | |||
There was a problem hiding this comment.
We can probably link directly to the page on site rather than linking to the repo here
Suggested change
| [backup]: https://github.com/etcd-io/website/blob/master/content/docs/v3.4.0/op-guide/recovery.md#snapshotting-the-keyspace | |
| [backup]: ./op-guide/recovery#snapshotting-the-keyspace |
| [chubby]: http://static.googleusercontent.com/media/research.google.com/en//archive/chubby-osdi06.pdf | ||
| [runtime reconfiguration]: https://github.com/etcd-io/etcd/blob/master/Documentation/op-guide/runtime-configuration.md | ||
| [runtime reconfiguration]: https://github.com/etcd-io/website/blob/master/content/docs/v3.4.0/op-guide/runtime-configuration.md |
There was a problem hiding this comment.
Suggested change
| [runtime reconfiguration]: https://github.com/etcd-io/website/blob/master/content/docs/v3.4.0/op-guide/runtime-configuration.md | |
| [runtime reconfiguration]: ./op-guide/runtime-configuration |
|
Hi @franciosi, thanks for this. I have a couple suggestions in the file changed. Would you also be willing to make these changes in the |
|
Yes, count on me |
Merged
|
As there have been a lot of changes to the site, I'm closing this in favour of #203. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just updating [backup] and [runtime reconfiguration] links