Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move historic metrics files #171

Merged
merged 3 commits into from
Mar 31, 2021

Conversation

nate-double-u
Copy link
Contributor

@nate-double-u nate-double-u commented Mar 29, 2021

If we do want to keep the historic metrics files, I think this is a reasonable way to organize them.

Closes #170

/cc @spzala @chalin @ptabor

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense IMHO to relocate the metrics files, but how are they meant to be accessed for the doc versions other than next? I'm not seeing a Generated list of metrics section for the v* metrics pages.

@nate-double-u
Copy link
Contributor Author

I'm not seeing a Generated list of metrics section for the v* metrics pages.

That's a good point. I'll update this PR with that.

adding generated list of metrics for each version that has them

Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
@chalin
Copy link
Contributor

chalin commented Mar 30, 2021

This is a good reorganization! Now that we have metrics files under the corresponding doc version folders, it would make sense to sort the entries (decreasing) on the path number.

This could be handled in another PR, if at all.

@nate-double-u
Copy link
Contributor Author

Thanks Patrice!

Now that we have metrics files under the corresponding doc version folders, it would make sense to sort the entries (decreasing) on the path number.

This could be handled in another PR, if at all.

I'd like to open a separate issue for resorting the lists -- during my docsy conversion explorations I found that we'll need to rewrite the shortcode that generates the list, so maybe we add resorting to that work?

@nate-double-u nate-double-u merged commit 3f4e45e into etcd-io:master Mar 31, 2021
@nate-double-u nate-double-u deleted the 170-move-metrics branch March 31, 2021 15:08
@nate-double-u nate-double-u mentioned this pull request Mar 31, 2021
34 tasks
@chalin chalin mentioned this pull request Apr 26, 2021
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review metrics files
2 participants