-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move historic metrics files #171
Conversation
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It makes sense IMHO to relocate the metrics files, but how are they meant to be accessed for the doc versions other than next? I'm not seeing a Generated list of metrics section for the v* metrics pages.
That's a good point. I'll update this PR with that. |
adding generated list of metrics for each version that has them Signed-off-by: Nate W <4453979+nate-double-u@users.noreply.github.com>
This is a good reorganization! Now that we have metrics files under the corresponding doc version folders, it would make sense to sort the entries (decreasing) on the path number. This could be handled in another PR, if at all. |
Thanks Patrice!
I'd like to open a separate issue for resorting the lists -- during my docsy conversion explorations I found that we'll need to rewrite the shortcode that generates the list, so maybe we add resorting to that work? |
If we do want to keep the historic metrics files, I think this is a reasonable way to organize them.
Closes #170
/cc @spzala @chalin @ptabor