Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added administration page #510

Closed
wants to merge 4 commits into from

Conversation

Somoshree
Copy link
Contributor

@Somoshree Somoshree commented Oct 1, 2021

@jberkus
Copy link
Contributor

jberkus commented Oct 5, 2021

I'm not sure that "Benchmarks" should be under Adminstration. That page is more of a PR thing, for the project. Thoughts, @nate-double-u @spzala ?

@nate-double-u
Copy link
Contributor

nate-double-u commented Oct 6, 2021

I'm not sure that "Benchmarks" should be under Adminstration. That page is more of a PR thing, for the project. Thoughts, @nate-double-u @spzala ?

I agree.

Should Metrics be moved under this new Administration section as well?

@jberkus
Copy link
Contributor

jberkus commented Oct 7, 2021

@nate-double-u I don't understand. I'm talking about NOT including benchmarks in administration.

@nate-double-u
Copy link
Contributor

@nate-double-u I don't understand. I'm talking about NOT including benchmarks in administration.

Sorry, you're right I got confused.

Copy link
Member

@spzala spzala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark should be on it's own level. I like the way it is right now.
Agree with @jberkus on not moving it under admin page.

@jberkus
Copy link
Contributor

jberkus commented Nov 19, 2021

Please remove the merge conflicts from this PR and I'll merge it.

@nate-double-u
Copy link
Contributor

There is a lot of work to do to fix the merge conflicts. Closing as stale.

Feel free to re open this if you've got time to work on it @Somoshree, we appreciate your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Administration page
4 participants