-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added administration page #510
Conversation
I'm not sure that "Benchmarks" should be under Adminstration. That page is more of a PR thing, for the project. Thoughts, @nate-double-u @spzala ? |
I agree.
|
@nate-double-u I don't understand. I'm talking about NOT including benchmarks in administration. |
Sorry, you're right I got confused. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark should be on it's own level. I like the way it is right now.
Agree with @jberkus on not moving it under admin page.
Please remove the merge conflicts from this PR and I'll merge it. |
There is a lot of work to do to fix the merge conflicts. Closing as stale. Feel free to re open this if you've got time to work on it @Somoshree, we appreciate your contributions! |
closes: #401
Deploy preview: https://deploy-preview-510--etcd.netlify.app/docs/v3.5/administration/