This repository has been archived by the owner on Oct 7, 2023. It is now read-only.
zketcd: initial multiop support #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiang90
reviewed
Jun 1, 2017
zketcd.go
Outdated
| @@ -186,17 +175,29 @@ func (z *zkEtcd) Ping(xid Xid, op *PingRequest) ZKResponse { | |||
| } | |||
|
|
|||
| func (z *zkEtcd) Delete(xid Xid, op *DeleteRequest) ZKResponse { | |||
| b := z.mkDeleteTxnOp(op) | |||
| resp, zkresp := z.doWrappedSTM(xid, b.apply) | |||
There was a problem hiding this comment.
resp, err := z.doWrappedSTM is more readable.
|
I took a very quick look. Everything seems reasonable. LGTM. |
Reworks create/delete/setdata into composable txn functions, then compose them into a single stm txn for atomicity. Also extends wire protocol to encode multiop responses. Fixes etcd-io#38
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks create/delete/setdata into composable txn functions,
then compose them into a single stm txn for atomicity. Also
extends wire protocol to encode multiop responses.
Fixes #38
Haven't been able to get clickhouse to issue multi-ops yet, so this is a first cut.
/cc @ztlpn