-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Testing Refactor #34
Testing Refactor #34
Conversation
lead, _ := cl.Leader() | ||
cl.Node(int(lead)).Stop() | ||
// wait for leader election timeout | ||
time.Sleep(cl.Node(0).e.tickDuration * defaultElection * 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you sleeping? Please find a way to not sleep.
Let's find a way to remove all of the sleeps soon. We can do that in another PR though. Is this ready to merge? |
@bmizerany Almost ready for merge. We can get rid of the timing. But need some extra work.
|
@xiangli-cmu refreshed. |
@unihorn i think we have achieved the 3 goals mentioned in this pr. lgtm. |
@unihorn This needs to be rebased. |
Okay. I haven't looked over 100% of it, so I'm defering to you two on this. LGTM. |
No description provided.