Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agharta/eip1014 create2 #20

Merged
merged 68 commits into from
Sep 3, 2019
Merged

Agharta/eip1014 create2 #20

merged 68 commits into from
Sep 3, 2019

Conversation

soc1c
Copy link
Contributor

@soc1c soc1c commented Aug 2, 2019

reapplying #5, can you make that mergable @dziabko? :)

dziabko and others added 30 commits May 31, 2019 16:01
@dziabko
Created branch & added new opcode into opcode.go file
a132148
@dziabko
Added create2 function
41bbc3e
@dziabko
Implemented create function for Create2 contracts
d429f60
@dziabko
Created branch & added new opcode into opcode.go file
12f6d55
@dziabko
Added create2 function
168ad8e
@dziabko
Implemented create function for Create2 contracts
e11e493
@dziabko
Rebased with development
c15505d
@dziabko
Finished Create2 opcode & cleaned up comments
7ecdb41
@dziabko
Created branch & added new opcode into opcode.go file
7470eed
@dziabko
Added create2 function
76dbb83
@austinabell @dziabko
Atlantis config (#50)
a6f4874 
* Added Atlantis fork in builtin mainnet and morden config

* Fixed difficulty test at 10_000_000 block (Atlantis)

* Added tests for Atlantis difficulty transition
@soc1c @dziabko
cmd/geth rename client (#52)
7e4db6a
@austinabell @dziabko
Added error handling for precompiles and removed skipped tests (#54)
a150c21
@austinabell @dziabko
Makefile and README updates (#49)
c292ca2 
* wip makefile updates

* Fixed makefile and updated README

* Fixed readme changes

* Added go module documentation and fixed wiki links to EP

* Added go modules on for makefile commands and documentation
@soc1c @dziabko
makefile: fix version string (#57)
c075707
@austinabell @dziabko
Dockerfile configuration (#56)
fd7c21b 
* Added Dockerfile setup

* Added Dockerfile setup

* Fixed build command

* Removed private repo authentication in Dockerfile
@austinabell @dziabko
Enforced go modules on for every part of the test command (#60)
22e6420
@soc1c @dziabko
docs: update readme (#59)
14c7b10 
* docs: update readme

* Update README.md

* Update README.md
@soc1c @dziabko
ci: prepare assets for release (#64)
990c0b4 
* ci: prepare assets for release

* ci: fix indentation

* ci: fix indentation

* ci: fix indentation

* ci: fix indentation

* ci: release in build step

* ci: calculate sha256sums

* ci: store artifacts

* ci: do a reverse copy

* ci: fix bash syntax

* ci: indicate os in release

* ci: pushd and pop'd ;)
@austinabell @dziabko
Receipt fixes and state trie clearing detail (#62)
7b757a0 
* receipt and state trie clearing changes

* Fixed receipt storage and added backward compatible decoding
@dziabko
Implemented create function for Create2 contracts
f06470d
@dziabko
Created branch & added new opcode into opcode.go file
17da13d
@dziabko
Added create2 function
7d66e9e
@dziabko
Implemented create function for Create2 contracts
0d23378
@dziabko
Finished Create2 opcode & cleaned up comments
4827c7d
@dziabko
Fixed merge conflicts while rebasing w/ development
0bd7b10
@dziabko
Created branch & added new opcode into opcode.go file
ddbfd17
@dziabko
Added create2 function
9ef238e
@austinabell @dziabko
Atlantis config (#50)
6beb8a9 
* Added Atlantis fork in builtin mainnet and morden config

* Fixed difficulty test at 10_000_000 block (Atlantis)

* Added tests for Atlantis difficulty transition
@soc1c @dziabko
cmd/geth rename client (#52)
e3f53a0
@soc1c soc1c added this to the 6.1 Agharta milestone Aug 12, 2019
@GregTheGreek GregTheGreek mentioned this pull request Aug 14, 2019
Closed
5 tasks
@steviezhang steviezhang mentioned this pull request Aug 15, 2019
Closed
austinabell
austinabell suggested changes Aug 19, 2019
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other PR for other changes to be done relating to Create2, but the logic for Create should not be changed in this PR

tests/state_test.go Outdated Show resolved Hide resolved
core/execution.go Outdated Show resolved Hide resolved
core/execution.go Outdated Show resolved Hide resolved
austinabell
austinabell suggested changes Aug 20, 2019
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple small details and then I'm good with it

core/execution.go Show resolved Hide resolved
tests/state_test.go Outdated Show resolved Hide resolved
core/execution.go Outdated Show resolved Hide resolved
core/execution.go Outdated Show resolved Hide resolved
core/execution.go Show resolved Hide resolved
austinabell
austinabell suggested changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change and I'll be good to merge this into the branch off development

core/execution.go Outdated Show resolved Hide resolved
core/execution.go Outdated Show resolved Hide resolved
@dziabko
Changed gas reference in create() to params.CreateDataGas. Changed ad…
6f3db42 
…dress from pointer to a regular in create().
@austinabell austinabell changed the base branch from development to agharta/dev August 22, 2019 15:39
austinabell
austinabell approved these changes Aug 22, 2019
View reviewed changes
Copy link
Contributor

@austinabell austinabell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@steviezhang steviezhang self-requested a review August 28, 2019 19:43
@GregTheGreek GregTheGreek merged commit 99a52af into agharta/dev Sep 3, 2019
@soc1c soc1c deleted the agharta/eip1014-create2 branch September 5, 2019 08:49
@soc1c
Copy link
Contributor Author

soc1c commented Sep 5, 2019

WTF why did you change the base branch @austinabell

@soc1c soc1c restored the agharta/eip1014-create2 branch September 5, 2019 08:51
@soc1c
Copy link
Contributor Author

soc1c commented Sep 5, 2019

the entire point of this PR is getting this into development!!!

@austinabell
Copy link
Contributor

@soc1c The agharta changes haven't even been approved by the community, why would we merge them into development now? There is no functional change what would be the benefit to this?

agharta/dev was just recently branched off of development so it would be ready to merge in whenever the changes are intended to be introduced (and would cause less conflict with the rename if grouped together)

@soc1c
Copy link
Contributor Author

soc1c commented Sep 5, 2019

development is unstable. everything goes into development

community approval is unrelated to our dev work

@GregTheGreek
Copy link
Contributor

have we re-megred this onto dev? @soc1c is correct..

@austinabell austinabell mentioned this pull request Sep 5, 2019
Merged
@austinabell
Copy link
Contributor

Just did it because that was what I was told to hahah, I changed other agharta PR's base and referenced new PR

@soc1c soc1c deleted the agharta/eip1014-create2 branch September 20, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GregTheGreek GregTheGreek GregTheGreek approved these changes

@austinabell austinabell austinabell approved these changes

@steviezhang steviezhang steviezhang approved these changes

@noot noot Awaiting requested review from noot

Assignees
No one assigned
Labels
PR: 6 Backport Priority: 2 High Type: Core
Projects
None yet
Milestone
6.1 Agharta
Development

Successfully merging this pull request may close these issues.
7 participants
@soc1c @austinabell @GregTheGreek @steviezhang @dziabko @noot @daniel399