Agharta/EIP1052 - extCodeHash #4

steviezhang · 2019-07-05T16:26:45Z

Implemented extCodeHash.

Note that we are now skipping a large amount of tests due to this being opened before Create2 has been implemented on development. All the below tests use the Create2 opcode and we will have to revisit them when Create2 is merged/on the Create2 branch:

	skipTests["codeCopyZero.json"] = "Create2 unimplemented"
	skipTests["dynamicAccountOverwriteEmpty.json"] = "Create2 unimplemented"
	skipTests["extCodeHashNewAccount.json"] = "Create2 unimplemented"
	skipTests["extCodeHashSelfInInit.json"] = "Create2 unimplemented"
	skipTests["extCodeHashSubcallOOG.json/ConstantinopleFix/0"] = "Create2 unimplemented"
	skipTests["extCodeHashSubcallOOG.json/ConstantinopleFix/1"] = "Create2 unimplemented"
	skipTests["extCodeHashSubcallOOG.json/ConstantinopleFix/2"] = "Create2 unimplemented"
	skipTests["extCodeHashCreatedAndDeletedAccount.json"] = "Create2 unimplemented"
	skipTests["extCodeHashCreatedAndDeletedAccountCall.json"] = "Create2 unimplemented"
	skipTests["extCodeHashCreatedAndDeletedAccountRecheckInOuterCall.json"] = "Create2 unimplemented"
	skipTests["extCodeHashCreatedAndDeletedAccountStaticCall.json"] = "Create2 unimplemented"
	skipTests["extCodeHashDeletedAccount3.json"] = "Create2 unimplemented"
	skipTests["extCodeHashDeletedAccount4.json"] = "Create2 unimplemented"
	skipTests["extCodeHashInInitCode.json/ConstantinopleFix/1"] = "Create2 unimplemented"
	skipTests["extCodeHashInInitCode.json/Constantinople/1"] = "Create2 unimplemented"

Additionally, we are skipping many Constantinople specific tests:

	skipTests["extCodeHashAccountWithoutCode.json/Constantinople/0"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashDynamicArgument.json/Constantinople/0"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashDynamicArgument.json/Constantinople/1"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashDynamicArgument.json/Constantinople/2"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashDynamicArgument.json/Constantinople/3"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashDynamicArgument.json/Constantinople/4"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashNonExistingAccount.json/Constantinople/0"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/0"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/1"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/2"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/3"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/4"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/5"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/6"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/7"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashPrecompiles.json/Constantinople/8"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashSubcallOOG.json/Constantinople/0"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashSubcallOOG.json/Constantinople/1"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashSubcallOOG.json/Constantinople/2"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashSubcallOOG.json/Constantinople/3"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashSubcallOOG.json/Constantinople/4"] = "Unsupported Gas Calculations"
	skipTests["extCodeHashSubcallOOG.json/Constantinople/5"] = "Unsupported Gas Calculations"
	skipTests["extCodeCopyBounds.json/Constantinople/0"] = "Unsupported Gas Calculations"

EDIT: We now skip Constantinople altogether

This is because we never underwent the revoked Constantinople fork, and so our calculations will only match up with post-St. Petersburg calculations

…ng to account being created and self-destructed in the same transaction

…used Create2

cmd/evm/main.go

core/vm/gas.go

core/vm/instructions.go

tests/state_test.go

… fork

noot · 2019-07-05T18:14:14Z

@steviezhang build fails

# github.com/eth-classic/go-ethereum/cmd/evm
cmd/evm/main.go:238:5: undefined: r
cmd/evm/main.go:238:31: undefined: num
cmd/evm/main.go:238:53: undefined: r

…ain and runtime

GregTheGreek · 2019-07-09T20:02:09Z

Lets merge #5 before this one.

* Created branch & added new opcode into opcode.go file * Added create2 function * Implemented create function for Create2 contracts * Created branch & added new opcode into opcode.go file * Added create2 function * Implemented create function for Create2 contracts * Finished Create2 opcode & cleaned up comments * Created branch & added new opcode into opcode.go file * Added create2 function * Atlantis config (#50) * Added Atlantis fork in builtin mainnet and morden config * Fixed difficulty test at 10_000_000 block (Atlantis) * Added tests for Atlantis difficulty transition * cmd/geth rename client (#52) * Added error handling for precompiles and removed skipped tests (#54) * Makefile and README updates (#49) * wip makefile updates * Fixed makefile and updated README * Fixed readme changes * Added go module documentation and fixed wiki links to EP * Added go modules on for makefile commands and documentation * makefile: fix version string (#57) * Dockerfile configuration (#56) * Added Dockerfile setup * Added Dockerfile setup * Fixed build command * Removed private repo authentication in Dockerfile * Enforced go modules on for every part of the test command (#60) * docs: update readme (#59) * docs: update readme * Update README.md * Update README.md * ci: prepare assets for release (#64) * ci: prepare assets for release * ci: fix indentation * ci: fix indentation * ci: fix indentation * ci: fix indentation * ci: release in build step * ci: calculate sha256sums * ci: store artifacts * ci: do a reverse copy * ci: fix bash syntax * ci: indicate os in release * ci: pushd and pop'd ;) * Receipt fixes and state trie clearing detail (#62) * receipt and state trie clearing changes * Fixed receipt storage and added backward compatible decoding * Implemented create function for Create2 contracts * Created branch & added new opcode into opcode.go file * Added create2 function * Implemented create function for Create2 contracts * Finished Create2 opcode & cleaned up comments * Created branch & added new opcode into opcode.go file * Added create2 function * Atlantis config (#50) * Added Atlantis fork in builtin mainnet and morden config * Fixed difficulty test at 10_000_000 block (Atlantis) * Added tests for Atlantis difficulty transition * cmd/geth rename client (#52) * Added error handling for precompiles and removed skipped tests (#54) * Makefile and README updates (#49) * wip makefile updates * Fixed makefile and updated README * Fixed readme changes * Added go module documentation and fixed wiki links to EP * Added go modules on for makefile commands and documentation * makefile: fix version string (#57) * Dockerfile configuration (#56) * Added Dockerfile setup * Added Dockerfile setup * Fixed build command * Removed private repo authentication in Dockerfile * Enforced go modules on for every part of the test command (#60) * docs: update readme (#59) * docs: update readme * Update README.md * Update README.md * ci: prepare assets for release (#64) * ci: prepare assets for release * ci: fix indentation * ci: fix indentation * ci: fix indentation * ci: fix indentation * ci: release in build step * ci: calculate sha256sums * ci: store artifacts * ci: do a reverse copy * ci: fix bash syntax * ci: indicate os in release * ci: pushd and pop'd ;) * Receipt fixes and state trie clearing detail (#62) * receipt and state trie clearing changes * Fixed receipt storage and added backward compatible decoding * Implemented create function for Create2 contracts * Created branch & added new opcode into opcode.go file * Added create2 function * Implemented create function for Create2 contracts * Finished Create2 opcode & cleaned up comments * Created branch & added new opcode into opcode.go file * Added create2 function * Added error handling for precompiles and removed skipped tests (#54) * Created branch & added new opcode into opcode.go file * Implemented create function for Create2 contracts * Added create2 function * Implemented create function for Create2 contracts * Rebased with development 2nd * Cleaned up code/comments & removed print statements. * Cleaned up comments & reverted go.mod & go.sum to original * Removed Constantinople tests & some tests involving non-implemented opcodes (EIP 145/1052) to pass CI. * Fixed removal of stBugs, stShift & stExtCodeHash tests * Fixed instructions_test salt parameter passed to CreateAddress2. * Changed local vars to camel case * Fixed error refactor. * Cleaned up comments. Skipped tests involving EIP684 (Collision). * Fixed error checking for evm.Run().

austinabell · 2019-07-26T14:45:58Z

tests/state_test.go

@@ -713,6 +713,23 @@ func TestAllETH(t *testing.T) {
 	// EIP 158/161 skipped tests
 	skipTests["RevertPrefoundEmptyOOG.json"] = "State trie clearing unimplemented"
 	skipTests["FailedCreateRevertsDeletion.json"] = "State trie clearing unimplemented"
+
+	//Create2 related skipped tests, all these tests use Create2 opcode


Should be able to remove these now, if they are related to Create2, since that is in now

austinabell · 2019-07-26T14:46:02Z

core/vm/jump_table.go

+		jumpTable[EXTCODEHASH] = jumpPtr{
+			fn:      opExtCodeHash,
+			valid:   true,
+    }


soc1c · 2019-08-02T07:48:20Z

changed base to development, waiting for reapplyication of #5 and #7

…e now failing

steviezhang · 2019-08-13T14:01:46Z

looks like the create2 rebase completely broke extcodehash, including previously passing tests, I'll sort through that in a bit

GregTheGreek · 2019-09-20T00:58:41Z

Let's get everything else merged & then do a re-base

GregTheGreek · 2019-10-18T07:23:42Z

Closing in favour of #55

steviezhang added 4 commits July 2, 2019 18:22

implemented EXTCODEHASH, need to figure out memory alloc in vm.go

0bef4da

fixed some issues with extCodeHash, we are still failing tests relati…

f4a2791

…ng to account being created and self-destructed in the same transaction

remove accidentally commited file

a106bce

Figured out why tests weren't passing, skipped irrelevant tests that …

37b1cec

…used Create2

steviezhang requested review from GregTheGreek, dziabko, austinabell, noot and soc1c July 5, 2019 16:26

removed fmt import

17af6f4

austinabell suggested changes Jul 5, 2019

View reviewed changes

cmd/evm/main.go Show resolved Hide resolved

core/vm/gas.go Outdated Show resolved Hide resolved

core/vm/instructions.go Outdated Show resolved Hide resolved

tests/state_test.go Outdated Show resolved Hide resolved

steviezhang changed the base branch from development to agharta/development July 5, 2019 16:40

soc1c removed their request for review July 5, 2019 16:40

steviezhang added 4 commits July 5, 2019 13:03

removed individual skipped tests, Added constantinople as unsupported…

a5e8995

… fork

added in case for Atlantis

81b841d

removed explicit gas price for extCodeHash

9b3cbe4

forgot to add additional argument to ruleSet struct

027d509

we can just have the gastable return agharta gastable as default in m…

3a48017

…ain and runtime

steviezhang requested a review from austinabell July 8, 2019 14:39

austinabell previously approved these changes Jul 9, 2019

View reviewed changes

dziabko and others added 3 commits July 10, 2019 17:51

Merge branch 'agharta/development' into stephanie/EIP1052-ExtCodeHash

caea68b

fixed failed build

aa77b4e

steviezhang dismissed austinabell’s stale review via aa77b4e July 11, 2019 13:44

steviezhang requested a review from austinabell July 11, 2019 14:57

austinabell suggested changes Jul 26, 2019

View reviewed changes

soc1c changed the base branch from agharta/development to development August 2, 2019 07:47

soc1c added PR: 1 Needs Review Priority: 5 Medium Type: Core labels Aug 2, 2019

soc1c added this to the 6.1 Agharta milestone Aug 12, 2019

GregTheGreek changed the title ~~EIP1052 - extCodeHash~~ Agharta/EIP1052 - extCodeHash Aug 12, 2019

fixed formatting, removed tests, looking into 2 create2 tests that ar…

b8c5ff5

…e now failing

GregTheGreek mentioned this pull request Aug 14, 2019

6.1.0 Beta Agharta Release Tracker #40

Closed

5 tasks

austinabell changed the base branch from development to agharta/dev August 22, 2019 15:40

austinabell changed the base branch from agharta/dev to development September 5, 2019 16:30

austinabell mentioned this pull request Sep 27, 2019

Agharta/EIP1052 EXTCODEHASH implementation #55

Merged

GregTheGreek closed this Oct 18, 2019

soc1c deleted the stephanie/EIP1052-ExtCodeHash branch November 4, 2019 15:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Agharta/EIP1052 - extCodeHash #4

Agharta/EIP1052 - extCodeHash #4

steviezhang commented Jul 5, 2019 •

edited

Loading

noot commented Jul 5, 2019 •

edited

Loading

GregTheGreek commented Jul 9, 2019

austinabell Jul 26, 2019

austinabell Jul 26, 2019

soc1c commented Aug 2, 2019

steviezhang commented Aug 13, 2019

GregTheGreek commented Sep 20, 2019

GregTheGreek commented Oct 18, 2019

Agharta/EIP1052 - extCodeHash #4

Agharta/EIP1052 - extCodeHash #4

Conversation

steviezhang commented Jul 5, 2019 • edited Loading

noot commented Jul 5, 2019 • edited Loading

GregTheGreek commented Jul 9, 2019

austinabell Jul 26, 2019

Choose a reason for hiding this comment

austinabell Jul 26, 2019

Choose a reason for hiding this comment

soc1c commented Aug 2, 2019

steviezhang commented Aug 13, 2019

GregTheGreek commented Sep 20, 2019

GregTheGreek commented Oct 18, 2019

steviezhang commented Jul 5, 2019 •

edited

Loading

noot commented Jul 5, 2019 •

edited

Loading