Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agharta/EIP1052 EXTCODEHASH implementation #55

Merged
merged 20 commits into from
Oct 18, 2019
Merged

Agharta/EIP1052 EXTCODEHASH implementation #55

merged 20 commits into from
Oct 18, 2019

Conversation

austinabell
Copy link
Contributor

Link to previous PR: #4

  • Also removes reference to ethereum code from create2 merge
  • nil check here for when extcodehash not existing in gas table (since gas consumption happens before op code check)
  • Removes all remaining skipped test directories (zk tests fixed by create2 I think)

steviezhang and others added 19 commits July 2, 2019 18:22
@steviezhang
implemented EXTCODEHASH, need to figure out memory alloc in vm.go
0bef4da
@steviezhang
fixed some issues with extCodeHash, we are still failing tests relati…
f4a2791 
…ng to account being created and self-destructed in the same transaction
@steviezhang
remove accidentally commited file
a106bce
@steviezhang
Figured out why tests weren't passing, skipped irrelevant tests that …
37b1cec 
…used Create2
@steviezhang
removed fmt import
17af6f4
@steviezhang
removed individual skipped tests, Added constantinople as unsupported…
a5e8995 
… fork
@steviezhang
added in case for Atlantis
81b841d
@steviezhang
removed explicit gas price for extCodeHash
9b3cbe4
@steviezhang
forgot to add additional argument to ruleSet struct
027d509
@steviezhang
we can just have the gastable return agharta gastable as default in m…
3a48017 
…ain and runtime
@austinabell
pull from development
1400f3d
@austinabell
second pull
ce1e72c
@austinabell
fix build issues
8a0b70e
@austinabell
Fixed reference
a79491f
@austinabell
Removed skipped test
39563f1
@austinabell
Fix spacing
81b7552
@austinabell
Add back gas consumption
18b3e0b
@austinabell
Add nil check for opcode
494824b
@austinabell
Remove skipped directories
d2d7779
amerameen
amerameen reviewed Oct 1, 2019
View reviewed changes
cmd/evm/main.go Show resolved Hide resolved
core/vm/runtime/runtime.go Outdated Show resolved Hide resolved
steviezhang
steviezhang previously requested changes Oct 4, 2019
View reviewed changes
Copy link
Contributor

@steviezhang steviezhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not passing whiteblock tests?

@austinabell
Copy link
Contributor Author

austinabell commented Oct 4, 2019 •
edited

Error: Post https://wbm-greg.boxes.whiteblock.io:5001/rpc: x509: certificate has expired or is not yet valid

@steviezhang @GregTheGreek

@amerameen
Copy link

Error: Post https://wbm-greg.boxes.whiteblock.io:5001/rpc: x509: certificate has expired or is not yet valid

@steviezhang @GregTheGreek

@steviezhang

What do we need to to do fix this on the CI? Seems like we need a working certificate?

@GregTheGreek
Copy link
Contributor

@noot

@GregTheGreek
Copy link
Contributor

@steviezhang @noot

@GregTheGreek GregTheGreek mentioned this pull request Oct 18, 2019
Closed
@GregTheGreek GregTheGreek dismissed steviezhang’s stale review October 18, 2019 07:26

Not requiring whiteblock

@GregTheGreek GregTheGreek merged commit a10e3ec into development Oct 18, 2019
@austinabell austinabell deleted the austin/rebase branch October 18, 2019 07:34
@GregTheGreek GregTheGreek mentioned this pull request Oct 21, 2019
Closed
5 tasks
@soc1c soc1c added this to the 6.1 Agharta milestone Oct 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amerameen amerameen amerameen approved these changes

@GregTheGreek GregTheGreek GregTheGreek approved these changes

@noot noot noot approved these changes

@steviezhang steviezhang steviezhang left review comments

@dziabko dziabko Awaiting requested review from dziabko

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1 Agharta
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@austinabell @amerameen @GregTheGreek @steviezhang @noot @soc1c