Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/vm,params: implement ECIP1086 #151

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

core/vm,params: implement ECIP1086 #151

wants to merge 4 commits into from

Commits on Feb 18, 2020

  1. core/vm,params: implement ECIP1086 

    Reference implementation of
https://github.com/ethereumclassic/ECIPs/blob/8c7fa04af31ceba09723c436e8f1ca1ef78a9b1c/_specs/ecip-1086.md

Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    20cdbe8 View commit details
    Browse the repository at this point in the history

  2. core/vm: (lint) goimports 

    Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    4c4a774 View commit details
    Browse the repository at this point in the history

  3. core/vm: make EIP2200Sloppy explicit about canonical SLOAD gas 

    This shows and defines verbosely the mistake addressed by ECIP1086,
where EIP2200 failed to implement SLOAD.constantGas=800.

Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    31f6434 View commit details
    Browse the repository at this point in the history

  4. core/vm: implement tests for ECIP1086 Kotti, ETCMainnet 

    Tests show that SLOAD gas never moves to 800 for Kotti or ETCMainnet
configs; this is the case for these networks for different reasons
(since Kotti implements ECIP1086, and ETCMainnet does not), but both
want eventually equivalent outcomes.

Signed-off-by: meows <b5c6@protonmail.com>
    @meowsbits
    meowsbits committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    a9232b2 View commit details
    Browse the repository at this point in the history