core/vm,params: implement ECIP1086 #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference implementation of https://github.com/ethereumclassic/ECIPs/blob/8c7fa04af31ceba09723c436e8f1ca1ef78a9b1c/_specs/ecip-1086.md Signed-off-by: meows <b5c6@protonmail.com>
Signed-off-by: meows <b5c6@protonmail.com>
This shows and defines verbosely the mistake addressed by ECIP1086, where EIP2200 failed to implement SLOAD.constantGas=800. Signed-off-by: meows <b5c6@protonmail.com>
Tests show that SLOAD gas never moves to 800 for Kotti or ETCMainnet configs; this is the case for these networks for different reasons (since Kotti implements ECIP1086, and ETCMainnet does not), but both want eventually equivalent outcomes. Signed-off-by: meows <b5c6@protonmail.com>
meowsbits
added a commit
to etclabscore/core-geth
that referenced
this pull request
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference implementation of
https://github.com/ethereumclassic/ECIPs/blob/8c7fa04af31ceba09723c436e8f1ca1ef78a9b1c/_specs/ecip-1086.md
Signed-off-by: meows b5c6@protonmail.com