Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking a task goes directly to edit page #81

Merged
merged 1 commit into from Feb 28, 2020

Conversation

AbleLincoln
Copy link
Contributor

Changes the user flow so that selecting a task bypasses the "Task view" and goes directly to the edit page.

@tasn
Copy link
Member

tasn commented Feb 28, 2020

Looks good to me, just one comment, could you make the commit messages conform to the rest of the commit messages? I know there's no style guideline at the moment (I should make one!) but you can see from existing messages. E.g. for this one, I'd make it: "Tasks: change clicking on task to go directly to edit page."

Edit: In case you are unware with git, you can just run git commit --amend to easily edit the last commit's commit message, and git push --force origin tasks/edit-flow to update this PR.

@AbleLincoln
Copy link
Contributor Author

Yeah whoops, I kind of messed that up haha. Give me a sec, I can fix

@tasn
Copy link
Member

tasn commented Feb 28, 2020

Cool. :)
Another cool git tool in case you are unfamiliar with it is: git rebase -i which lets you edit history. So you can for example, in this case run git rebase -i HEAD~4 which will let you squash together the last few commits, reorder them, reword them and whatever.

@AbleLincoln
Copy link
Contributor Author

Does this work?

@tasn tasn merged commit 059abe4 into etesync:master Feb 28, 2020
@AbleLincoln AbleLincoln deleted the tasks/edit-flow branch February 28, 2020 22:56
@tasn
Copy link
Member

tasn commented Feb 28, 2020

Yup, good job! Sorry again for all of the hassle, but there's quite a bit of code involved and quite a few commits, so I'd rather we do things right from the start, even with these small changes. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants