Resolve long tree string problem on Windows #258

[davidhwyllie]

There is a problem in which large newick trees fail to load from strings in windows, as described in issue #258. This arises because the existing read_newick code code performs os.path.exists() on a string passed to it. This string may either be a path to a file, or a newick file's contents.

On windows, os.path.exists() fails with very long strings, because very long strings causes stat to fail.

This proposed fix
a) includes a self contained unit test demonstrating the problem
b) traps for the ValueError raised when stat fails, and regards such a failure as evidence that the user has supplied a newick tree content, not a file name.

[davidhwyllie]

Pull request is at
#405

[davidhwyllie]

Dear Jaime

I'm not clear whether these failures are anything to do with the change - e.g.

sh: 0: Can't open /etc/init.d/xvfb
The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during .

Please let me know if more input would be helpful.
Thank you
David

[jhcepas]

This looks like a problem in the Travis image. Did not change in our side, so we may need to upgrade the config for the automated tests...

…

On Sat, 29 Jun 2019 at 21:57, David Wyllie ***@***.***> wrote: Dear Jaime I'm not clear whether these failures are anything to do with the change - e.g. sh: 0: Can't open /etc/init.d/xvfb The command "sh -e /etc/init.d/xvfb start" failed and exited with 127 during . Please let me know if more input would be helpful. Thank you David — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#405?email_source=notifications&email_token=AABH6STQH2LHDVLLN6MAWWDP465BPA5CNFSM4HPBX3U2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY37F7A#issuecomment-506983164>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AABH6SRKBEYZ24O53V6T4OTP465BPANCNFSM4HPBX3UQ> .