Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to lolsrv and more resilient when using Github API #2

Merged
merged 2 commits into from
Dec 6, 2013

Conversation

drewwells
Copy link
Contributor

Add shotgun and Guard for faster, better, stronger development
Consume NEW url and timestamp fields from plugin lolcommits/lolcommits#181
Rely on timestamp data when Github API call is not successful
Github API auth
Turned on Sintra config magic
Switched to modular Sintra for less config loading overhead
Google API keys read from environment, when available (reads from heroku when deployed)

Style updates and JS optimizations via lazy loading
Specify directly what size the images are
Prefer time field, it's more often available

Add shotgun and Guard for faster, better, stronger development
Consume NEW url and timestamp fields from plugin lolcommits/lolcommits#181
Rely on timestamp data when Github API call is not successful
Github API auth
Turned on Sintra config magic
Switched to modular Sintra for less config loading overhead
Google API keys read from environment, when available (reads from heroku when deployed)

Style updates and JS optimizations via lazy loading
Specify directly what size the images are
Prefer time field, it's more often available
@eteubert
Copy link
Owner

eteubert commented Dec 6, 2013

Thanks for the PR, looks awesome!
I must admit I'm not familiar with that Sinatra style. I just checked out your PR and am not getting it to work (getting 404s on all Sinatra routes). Is the setup different now from what's described in the readme.md?

@eteubert
Copy link
Owner

eteubert commented Dec 6, 2013

Oh I got it, I just need to call shotgun! Nevermind. I'll play around a bit with it but will merge soon.

@drewwells
Copy link
Contributor Author

Yep shotgun will work. Sorry I forgot to add run instructions in the README. I updated the config.ru so Heroku works automagically. You can use rackup to run it when not needing a file watcher.

rackup -p {port}

port is optional

eteubert added a commit that referenced this pull request Dec 6, 2013
Enhancements to lolsrv and more resilient when using Github API
@eteubert eteubert merged commit 58b5aee into eteubert:master Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants