Send more VCS details to lolsrv #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolsrv more repository agnostic.
Additional information includes:
* full repo details {user}/{repo}
* Timestamps of files
* Full URL of commit built from the commit remote path
drewwells
added a commit
to drewwells/lolsrv
that referenced
this pull request
Dec 6, 2013
Add shotgun and Guard for faster, better, stronger development Consume NEW url and timestamp fields from plugin lolcommits/lolcommits#181 Rely on timestamp data when Github API call is not successful Github API auth Turned on Sintra config magic Switched to modular Sintra for less config loading overhead Google API keys read from environment, when available (reads from heroku when deployed) Style updates and JS optimizations via lazy loading Specify directly what size the images are
drewwells
added a commit
to drewwells/lolsrv
that referenced
this pull request
Dec 6, 2013
Add shotgun and Guard for faster, better, stronger development Consume NEW url and timestamp fields from plugin lolcommits/lolcommits#181 Rely on timestamp data when Github API call is not successful Github API auth Turned on Sintra config magic Switched to modular Sintra for less config loading overhead Google API keys read from environment, when available (reads from heroku when deployed) Style updates and JS optimizations via lazy loading Specify directly what size the images are Prefer time field, it's more often available
| @@ -13,7 +13,9 @@ def initialize | |||
| self.message = commit.message.split("\n").first | |||
| self.sha = commit.sha[0..10] | |||
| self.repo_internal_path = g.repo.path | |||
| regex = /.*[:\/]([\w\-]*).git/ | |||
| self.url = g.remote.url ? g.remote.url.gsub(':','/').gsub(/^git@/,'https://').gsub(/\.git$/,'') + '/commit/': '' | |||
There was a problem hiding this comment.
seems like a rather lengthy expression here, maybe move this to a separate (private) method in this class? E.g.
def remote_https_url(url)
url.gsub(':','/').gsub(/^git@/,'https://').gsub(/\.git$/,'') + '/commit/'
end
# call with this (i think having self.url == nil is probably OK)
self.url = remote_https_url(g.remote.url) if g.remote.url
|
👍 Looks great, (just one minor comment) otherwise I think it's merge-able. |
|
Anything holding this up now? |
| :repo => self.runner.repo, | ||
| :date => File.ctime(file), | ||
| :sha => sha) | ||
| rescue => error |
There was a problem hiding this comment.
this should be rescue => e
|
couple more minor comments, otherwise good to go I think 👍 |
|
Thanks, looks OK to me now, merging 👍 |
matthutchinson
added a commit
that referenced
this pull request
Jan 1, 2014
Send more VCS details to lolsrv
|
released just now, in v0.5.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This data is useful for making lolsrv more repository agnostic.
Additional information includes:
These features are blocking eteubert/lolsrv#2