Apply auth error message to 404 responses too. #1052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnattishness
force-pushed
the
fix-http-response
branch
from
e4a0c87
to
c19ead3
Compare
Update CHANGELOG
gnattishness
force-pushed
the
fix-http-response
branch
from
c19ead3
to
3932534
Compare
iamdefinitelyahuman
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Adjusted error messages when interacting with the Github API.
Related issue: Fixes #1051
How to verify it
Can try a failing auth request e.g.
brownie pm install org/some_private_repo@1.2.3.Pretty clear from inspection too
Checklist