Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow overwriting the balance member if a contract defines it #721

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Allow overwriting the balance member if a contract defines it #721

merged 1 commit into from
Aug 18, 2020

Conversation

fubuloubu
Copy link
Contributor

What I did

Patches: #718

How I did it

Intercept, and added a warning

How to verify it

Write a test that uses it

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation
  • I have added an entry to the changelog

iamdefinitelyahuman
iamdefinitelyahuman previously approved these changes Aug 18, 2020
View reviewed changes
Copy link
Member

@iamdefinitelyahuman iamdefinitelyahuman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ideal but it's a good temporary fix until v2, Soon:tm:

@iamdefinitelyahuman iamdefinitelyahuman merged commit 132f4fd into eth-brownie:master Aug 18, 2020
@fubuloubu fubuloubu deleted the patch-2 branch August 18, 2020 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamdefinitelyahuman iamdefinitelyahuman iamdefinitelyahuman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fubuloubu @iamdefinitelyahuman