Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build.sh prints shfmt warning even with --minify=none #30

Closed
lilyball opened this issue May 4, 2020 · 2 comments
Closed

build.sh prints shfmt warning even with --minify=none #30

lilyball opened this issue May 4, 2020 · 2 comments

Comments

@lilyball
Copy link

lilyball commented May 4, 2020

The problem seems to be that the shfmt warning is gated with ! will_minify none but the implementation of will_minify is expecting either any or "" for this check.
eth-p added a commit that referenced this issue May 4, 2020
@eth-p
build: Print shfmt error to stderr instead of stdout (#30)
18c74ee
eth-p added a commit that referenced this issue May 4, 2020
@eth-p
build: Fix 'will_minify none' not working, leading to unnecessary war…
529eb60 
…ning (#30)
@eth-p
Copy link
Owner

eth-p commented May 4, 2020

Fixed, thanks!

@lilyball
Copy link
Author

lilyball commented May 7, 2020

Confirmed fixed.

@lilyball lilyball closed this as completed May 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lilyball @eth-p