Select character with keyboard #152
Merged
+43
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ethanmoffat
requested changes
Mar 26, 2022
| @@ -168,6 +174,12 @@ protected virtual async Task DeleteButtonClick() | |||
| protected virtual void DoUpdateLogic(GameTime gameTime) | |||
| { | |||
| _characterControl.Update(gameTime); | |||
|
|
|||
| var keyboardState = _userInputProvider.CurrentKeyState; | |||
| if (keyboardState.IsKeyDown((Microsoft.Xna.Framework.Input.Keys)49+_characterIndex)) | |||
There was a problem hiding this comment.
I think you want to check currentState.KeyUp and previousState.KeyDown for this, otherwise holding the key will spawn a bunch of tasks. The interlocked guard happens in LoginButtonClick so it won't stop the tasks from being started (and then immediately exiting).
There was a problem hiding this comment.
I switched to using IsKeyPressedOnce
| @@ -168,6 +174,12 @@ protected virtual async Task DeleteButtonClick() | |||
| protected virtual void DoUpdateLogic(GameTime gameTime) | |||
| { | |||
| _characterControl.Update(gameTime); | |||
|
|
|||
| var keyboardState = _userInputProvider.CurrentKeyState; | |||
| if (keyboardState.IsKeyDown((Microsoft.Xna.Framework.Input.Keys)49+_characterIndex)) | |||
There was a problem hiding this comment.
Can you do Keys.D1+_characterIndex? I think C# is pretty flexible with adding values to enums in this way.
Also, just add the using statement instead of fully qualifying the type here. FYI you can easily add the using Microsoft.Xna.Framework.Input via the keyboard shortcut CTRL+. in VS
sorokya
force-pushed
the
select-character-with-keyboard
branch
from
58eb7f7
to
73a7efc
Compare
sorokya
force-pushed
the
select-character-with-keyboard
branch
from
73a7efc
to
e727b88
Compare
ethanmoffat
approved these changes
Mar 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemed like a fun feature to implement and get my hands dirty with the client.
No idea if this is the "correct" way to deal with adding keyboard handling to a component.
Let me know if there's a better way and I can fix it :)