Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prettier config, standardized import-sort, dependency updates #1

Merged
merged 7 commits into from Sep 8, 2019

Conversation

fatso83
Copy link

@fatso83 fatso83 commented Sep 5, 2019

Makes all formatting consistent

@ethanresnick
Copy link
Owner

I'm happy to add in prettier, but only with the default config (i.e., no .prettierrc). My take on prettier is that a big part of its value comes from helping teams/projects avoid pointless fights over style — but adding in a config file just reopens those fights (now you're fighting over what should go in the config).

@fatso83
Copy link
Author

fatso83 commented Sep 6, 2019

Sure, I have Prettier run on save in vim, and that resulted in lots of changes, so I tried adding a configuration to minimize the amount of changes (single vs double quotes, for instance).

I could change this to remove the configuration and add a Husky commit hook that runs Prettier instead? This would result in lots more changes though.

@fatso83
Copy link
Author

fatso83 commented Sep 6, 2019

Doing it.

@fatso83
Copy link
Author

fatso83 commented Sep 6, 2019

Did some smaller chores in the same PR (see commit list).

@fatso83 fatso83 changed the title Add Prettier config Prettier config, standardized import-sort, dependency updates Sep 6, 2019
Copy link
Owner

@ethanresnick ethanresnick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! See comments

package.json Show resolved Hide resolved
src/buildMatchSnapshot.js Outdated Show resolved Hide resolved
@fatso83
Copy link
Author

fatso83 commented Sep 8, 2019

Fixed comment

@ethanresnick ethanresnick merged commit 82ea1fe into ethanresnick:master Sep 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants