Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newest Jest Snapshot #2

Merged
merged 1 commit into from Sep 5, 2019

Conversation

fatso83
Copy link

@fatso83 fatso83 commented Sep 5, 2019

Has breaking API changes

Has breaking API changes
@ethanresnick
Copy link
Owner

Thanks for this! I've merged. I wish this hadn't changed the import quote style (that just messes up git blame, distracts from the real changes in the diff), but not a blocker.

@ethanresnick ethanresnick merged commit 4deedc2 into ethanresnick:master Sep 5, 2019
@ethanresnick
Copy link
Owner

FYI, I've fixed the tests here and republished this to npm as 3.0.0

@fatso83
Copy link
Author

fatso83 commented Sep 6, 2019

Sorry for not running tests in #2. I created the PR in a rush to submit it before picking up from day-care after discovering UNDEFINED in my snapshots (basically jestjs/jest#5786), a by-product of upgrading react-redux.

I wouldn't normally submit a diff with unrelated changes either (which is why I made #1). Better luck next time, eh? :-)

@ethanresnick
Copy link
Owner

All good man. Thanks for figuring out the 23->24 API changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants