-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added helpers to collectContentPre and collectContentPost #2542
Conversation
Function makeContentCollector is used on both sides (client/server) but sometimes we need read somethings from html attribute. and passing data by class is very not elegant way.
Please read contributing.md for style guide, your indentation looks incorrect here..? |
Sorry, I copied and pasted it from my local version. In my bitbucket repository I have many core changes, Sometimes I change formatting of some files because I hate if '{' is in new line. When I will be have free moment, I am going to fix formatting. |
Bump @cristo-rabani |
check now |
src/static/js/contentcollector.js
Outdated
var helpers = { | ||
//returns attributes like style, id | ||
getAttr: function(htmlAttr){ | ||
return dom.nodeAttr(node, htmlAttr); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spacing still wrong here..
@cristo-rabani sorry dude there are merge conflicts :! My bad, that file is active! Can you please resolve the merge conflict please? One thing I would like is an example snippit of the helpers being used in a plugin so others can reference this.. I'd also like to see some docs be included, contentCollectorPre is exposed to plugins so the additional functionality needs docs to land in http://etherpad.org/doc/v1.5.0/#index_collectcontentpre Once we have:
Then this is good to merge Thanks! |
Another bump @cristo-rabani if you want to see this land... |
Closing as stale. |
Function makeContentCollector is used on both sides (client/server)
but sometimes we need read somethings from html attribute.
and passing data by class is very not elegant way.