Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Minify Simplification #468

Merged
merged 23 commits into from Feb 27, 2012

Conversation

Projects
None yet
3 participants
Contributor

cweider commented Feb 20, 2012

After #449 is pulled, even more code can be removed from Minify. This removes all the JS packaging code from Minify (using the yajsml middleware). These are the significant changes:

  • Only serves individual static files and installed at static/*.
  • Serves/compress all JS and CSS.
  • The ace.js file gets embedded content from internal HTTP requests.
  • LastModified/304’s are much more specific page loads much faster in development.

The internal HTTP requests that both Minify and Yajsml need some scrutiny - I’m not sure if odd environments (the motivation for relative paths) will cause any trouble (my guess is not).

This was referenced Feb 27, 2012

Pita added a commit that referenced this pull request Feb 27, 2012

@Pita Pita merged commit 611cfbd into ether:master Feb 27, 2012

Contributor

Pita commented Feb 27, 2012

all merged, thx

rossmeissl added a commit to faradayio/etherpad-lite-heroku that referenced this pull request Apr 10, 2012

Revert "Merge pull request #468 from cweider/minify-simplify"
This reverts commit 611cfbd, reversing
changes made to bf42359.

Conflicts:

	node/server.js
	node/utils/Minify.js
	node/utils/Settings.js
	node/utils/caching_middleware.js
	package.json
	settings.json.template
	static/pad.html
	static/timeslider.html

From what I can tell this merge has significantly reduced the reliability of etherpad-lite running at beta.etherpad.org

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment