Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Party CRUD + UI View #26

Closed
lalalune opened this issue Apr 11, 2020 · 11 comments
Closed

Party CRUD + UI View #26

lalalune opened this issue Apr 11, 2020 · 11 comments
Assignees

Comments

@lalalune
Copy link

lalalune commented Apr 11, 2020

Purpose of this feature:
This is like a "party" system in a video game. User A sends user B a request to join User A's party.

This might be expressed as a teacher and a class full of kids. When the teacher presses the button to enter a new world, it will instruct the kids to go with them into this room.

Step 1 -- Create the service (done)
Step 2 -- Associate with users
Step 3 -- Add to party, join party, remove from party and leave party
Step 4 -- Integrate with gameserver and instances for event messages like joining a new server.

Parties are small, ephemeral groups of users. There must be at least two people in a party for it to exist -- otherwise it is destroyed automatically.

Parties have their own chat, and party members can join each other's worlds. Party leaders can invite and kick party members from the party. When a party leader joins a location, every other party member will see an offer to join with them.

Party members can also join the room of any other member at any time, although the intention is that this feature will simplify helping groups all join the same room together.

@lalalune lalalune created this issue from a note in Alpha MVP - May 14 (Todo: Backend) Apr 11, 2020
@dmitrizagidulin
Copy link
Collaborator

@shawticus Excellent.
How do you feel about modeling this (or at least being able to export to) a vCard Group? (which means it'll sync natively with iOS and Android groups, etc)

@lalalune
Copy link
Author

Sounds good to me

@dmitrizagidulin dmitrizagidulin added this to the 02 - KaiXR milestone Apr 15, 2020
@lalalune lalalune moved this from Todo: Backend to Todo: Fullstack in Alpha MVP - May 14 Apr 16, 2020
SaadAhmedSiddiqui added a commit that referenced this issue Apr 18, 2020
@dmitrizagidulin dmitrizagidulin moved this from Todo: Fullstack to Todo: Backend in Alpha MVP - May 14 Apr 19, 2020
@lalalune lalalune moved this from Todo: Backend/Ops to In Progress in Alpha MVP - May 14 Apr 19, 2020
@lalalune
Copy link
Author

Changed this so that group members all have an isLeader flag -- there is no 'owner' of the group.

We will need to review logic to delete the group when all members leave.

@lalalune lalalune moved this from In Progress to Awaiting Review in Alpha MVP - May 14 Apr 21, 2020
@lalalune
Copy link
Author

@SaadAhmedSiddiqui when you've finished your current task, please take a look at this. We've redefined our models quite a bit and need to update the group assignment logic. I believe most of the group code is commented out.

@SaadAhmedSiddiqui
Copy link

@shawticus same for this!

@lalalune
Copy link
Author

@barankyle please review

@dmitrizagidulin
Copy link
Collaborator

@SaadAhmedSiddiqui Is there a PR of the code in progress we can look at?

@SaadAhmedSiddiqui
Copy link

@dmitrizagidulin there is no PR for this because Step#4 is not completed yet

@dmitrizagidulin
Copy link
Collaborator

@SaadAhmedSiddiqui That's fine, can you please make a PR of the code in progress, before step 4?

@lalalune lalalune changed the title Group List Party Apr 29, 2020
@lalalune lalalune moved this from To Task to Todo: Client in Alpha MVP - May 14 May 11, 2020
@lalalune lalalune removed this from Todo: Client in Alpha MVP - May 14 May 11, 2020
@lalalune lalalune added this to Client / UI/UX Implementation in v0.01 - July 23 - Foundational Build May 11, 2020
@lalalune lalalune removed this from Client / UI/UX Implementation in v0.01 - July 23 - Foundational Build May 25, 2020
@lalalune lalalune added this to Client / UI/UX Implementation in v0.01 - July 23 - Foundational Build May 25, 2020
@dmitrizagidulin dmitrizagidulin removed this from Client / UI/UX Implementation in v0.01 - July 23 - Foundational Build Jun 6, 2020
lalalune added a commit that referenced this issue Jun 7, 2020
Added landing page and 360 video gallery.
@lalalune lalalune moved this from Client/UI to Server in v0.2 - August 31 - Beta Release Jul 3, 2020
@lalalune lalalune moved this from Client to WebGL in v0.3 - September 14 - Release Candidate Jul 3, 2020
@lalalune lalalune added this to To Do in November 1 Jul 3, 2020
@lalalune lalalune removed this from To Do in November 1 Jul 3, 2020
@mrhegemon
Copy link
Member

Review and close
#168
#217

@barankyle
Copy link
Member

Mostly implemented as part of #345. Parties work very similarly to groups. The requirement that there must be two people in a party has been ignored for now. Logic for invites to all party members to join a world hasn't been done since joining worlds is still in progress; a new issue should be created when we want to do that.

v0.1 - August 15 - Functional MVP automation moved this from In Progress to Completed Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants