Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing explorers, faucet and fixed some ids #463

Merged
merged 21 commits into from
Oct 10, 2021

Conversation

porkybalboa
Copy link
Contributor

No description provided.

@ligi
Copy link
Member

ligi commented Oct 8, 2021

Thanks for the PR! There is useful stuff in there - just a bit torn about 2 things:

  • the faucet has rekt.al in the top - which is really weird and maybe not nice for some users in a language that I speak unfortunately - if we add this faucet we should really add parameters for chain and address so the UX is better when using
  • some explorers like the celo one do not respect EIP3091 - wondering now if it is better to make the standard field optional. On the other side we had some cases where people adopted EIP3091 to get an explorer in the data.

@porkybalboa
Copy link
Contributor Author

* EIP3091

you are right, i got the faucet admin to remove the questionable domain name :)

@porkybalboa
Copy link
Contributor Author

* some explorers like the celo one do not respect EIP3091 - wondering now if it is better to make the standard field optional. On the other side we had some cases where people adopted EIP3091 to get an explorer in the data.

i noticed the latest version of blockscout respect the uri route schema from the EIP3091 along with their old routes in parallel. i guess some customized forks based of older blockscouts probably miss this change. but along my multichain adventures i hardly came across these.
maybe leave the stand-field in, urging devs to adopt the EIP. by itself patching in these routes should no problem for someone who is able to customize a blackexplorer. once the users complain that their explorer links do not work expectedly they will be quick to adopt, i guess.


"explorers": [{
"name": "blockscout",
"url": "https://explorer.celo.org",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this explorer does not respect EIP3091

_data/chains/eip155-1285.json Outdated Show resolved Hide resolved
_data/chains/eip155-19.json Outdated Show resolved Hide resolved
_data/chains/eip155-42220.json Outdated Show resolved Hide resolved
_data/chains/eip155-43114.json Outdated Show resolved Hide resolved
_data/chains/eip155-61.json Outdated Show resolved Hide resolved
@ligi ligi merged commit 2718c10 into ethereum-lists:master Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants