Skip to content
This repository has been archived by the owner on Apr 24, 2022. It is now read-only.

Fix CUDA driver version check. #1389

Merged

Conversation

StefanOberhumer
Copy link
Collaborator

@StefanOberhumer StefanOberhumer commented Jul 26, 2018

When accessing CUDAMiner, CUDAMiner::getNumDevices() is
called which can cause an exception.
Catch the exception, display the error message and exit.

Found this problem while searching solution for ISSUE #1378 - maybe this solves the problem.

When accessing CUDAMiner, CUDAMiner::getNumDevices() is
called which can cause an exception.
Catch the exception, display the error message and exit.
@smurfy
Copy link
Collaborator

smurfy commented Jul 26, 2018

Well, while i like this change, why exit at all if cuda is not present?

@StefanOberhumer
Copy link
Collaborator Author

StefanOberhumer commented Jul 26, 2018

@smurfy

Well, while i like this change, why exit at all if cuda is not present?

If a user requests CUDA ( -U or -X ) I think we should exit if CUDA fails (currently ethminer "just" segfaults ;-) ).

@smurfy
Copy link
Collaborator

smurfy commented Jul 26, 2018

On -U, yes but on -X i do not know. For example i like to have just "one" commandline script for my amd and nvidia cards, so i would like to use -X, which exited in the past due to cuda error even if used on an amd only rig. (i think it still does)

I have nothing against the warning/error popup, just why exit?. While not everything is great what claymore does, the handling of mixed rigs/gpu detection and miner type is great with it.
But i think this is something for the future.

@StefanOberhumer
Copy link
Collaborator Author

On -U, yes but on -X i do not know. For example i like to have just "one" commandline script for my amd and nvidia cards, so ....

You're right - may be we can address this in the future.

@MariusVanDerWijden MariusVanDerWijden merged commit ac7f170 into ethereum-mining:master Jul 27, 2018
@StefanOberhumer StefanOberhumer deleted the FixCUDAVersionCheck branch July 27, 2018 10:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants