Update create-l2-rollup.mdx fix sync() issue #651
Conversation
for branch tutorials/chain , if using the latest forge version , it will failed to run forge script scripts/Deploy.s.sol:Deploy --sig 'sync()' --rpc-url $L1_RPC_URL with error info "Deploy Tx not found" the root cause is the contract address is lower in : broadcast/Deploy.s.sol/11155111/run-latest.json but its not lowercase in deployments/getting-started/.deploy
WalkthroughThe update includes a cautionary note about using a specific version of Changes
Possibly related issues
Recent Review DetailsConfiguration used: .coderabbit.yaml Files selected for processing (1)
Additional Context UsedLanguageTool (163)
Path-based Instructions (1)
Additional comments not posted (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
✅ Deploy Preview for docs-optimism ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -101,6 +101,8 @@ You may experience unexpected errors on older versions of Node.js. | |||
| #### `foundry` | |||
|
|
|||
| It's recommended to use the scripts in the monorepo's `package.json` for managing `foundry` to ensure you're always working with the correct version. This approach simplifies the installation, update, and version checking process. Make sure to clone the monorepo locally before proceeding. | |||
|
|
|||
| for forge , please use https://github.com/foundry-rs/foundry/releases/tag/nightly-5b7e4cb3c882b28f3c32ba580de27ce7381f415a, latest version of forge will cause address Lowercase issue and fail the sync() method | |||
There was a problem hiding this comment.
We should avoid pinning a specific version in the docs. We specify the version inside the monorepo and relatively frequently update it.
There was a problem hiding this comment.
so far only this version works with the "Creating Your Own L2 Rollup Testnet" doc, other version I tested (latest 2 version of forge ) ,failed because of the Lowercase @trianglesphere
|
This tutorial is currently getting updated here #657. I'm working with the team internally to figure out how to get the best practices in here. |
|
closing, see @sbvegan comment above |
Description
for branch tutorials/chain , if using the latest forge version , it will failed to run
forge script scripts/Deploy.s.sol:Deploy --sig 'sync()' --rpc-url $L1_RPC_URLwith error info
"Deploy Tx not found"the root cause is the contract address is lower in : broadcast/Deploy.s.sol/11155111/run-latest.json
but its not lowercase in deployments/getting-started/.deploy
Tests
sync success
Additional context
bug of https://docs.optimism.io/builders/chain-operators/tutorials/create-l2-rollup
by the way , anyone please fix the doc if its outdated
Metadata