geth: add flag to control auto db compaction #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anacrolix
approved these changes
Aug 6, 2024
anacrolix
force-pushed
the
seb/db-comp-flag
branch
from
e97f61e
to
b61cdae
Compare
|
I just spotted the do-not-merge label. What's the story there? |
|
We tested this and it's not working. The database needs regular compactions, so just disabling it doesn't work, and in fact the node dies after a few minutes. There are other parameters that we could try out tweaking, see this more general PR: #322 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a flag to control automatic db compaction for the pebble db backend.
Tests
None, this is a new geth node flag. Added a log message so we can confirm the setting is applied when starting a node with this new flag.
Metadata