feat/interop: update L1BlockInterop

[0xfuturistic]

L1BlockInterop is updated according to the updates to the specs. This PR implements the L1BlockInterop, L1Block changes from #10452, which was closed in support of smaller PRs

[coderabbitai]

Walkthrough

The recent updates bring significant enhancements to the contracts-bedrock package, focusing on improving interop dependency management, error handling, and configuration settings. Key changes include the integration of EnumerableSet, new error and event definitions, and refined functions for handling gas-paying tokens and dependencies. Additionally, new encoding functions and tests have been added to ensure robust functionality and interoperability within the L2 system.

Changes

File Path	Change Summary
L1BlockInterop.sol	Added EnumerableSet, ConfigType enum, new error types and events, refactored functions for dependency management and configuration updates.
differential-testing.go, utils.go	Added cases and functions for encoding gas-paying tokens and dependencies with parsing and encoding logic.
L1Block.sol	Imported L1BlockErrors.sol and removed NotDepositor() error declaration.
L1BlockErrors.sol	Introduced error definitions for depositor accounts, chain IDs, and interop dependency sets.
StaticConfig.sol	Updated functions for encoding and decoding static configuration data, reflecting a shift to setting gas-paying tokens.
StaticConfig.t.sol	Added testing utilities for encoding/decoding gas-paying tokens and dependencies using the StaticConfig contract.
FFIInterface.sol	Added functions for encoding token and dependency data.
L2Genesis.s.sol	Added conditional logic in setL1Block for handling different scenarios based on cfg.useInterop().

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Out of diff range and nitpick comments (1)

packages/contracts-bedrock/src/L2/L1BlockInterop.sol (1)

5-6: Consider documenting the purpose of the new imports.

Adding comments to explain why EnumerableSetLib and GasPayingToken are imported could improve code readability and maintainability.

[coderabbitai]

Actionable comments posted: 1

[tynes]

Needs tests but code structure is good

[0xfuturistic]

Needs tests but code structure is good

@tynes tests are in this PR: #10571

[coderabbitai]

Actionable comments posted: 1

[coderabbitai]

Actionable comments posted: 2

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.26%. Comparing base (7c0661e) to head (f82a2f0).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff              @@
##           develop   #10584       +/-   ##
============================================
- Coverage    55.13%   39.26%   -15.88%     
============================================
  Files           37       27       -10     
  Lines         2900     1821     -1079     
  Branches       415      415               
============================================
- Hits          1599      715      -884     
+ Misses        1269     1106      -163     
+ Partials        32        0       -32     

Flag	Coverage Δ
cannon-go-tests	?
chain-mon-tests	27.14% <ø> (ø)
sdk-tests	40.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 10 files with indirect coverage changes