Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): add Bedrock support to SDK #3086

Merged
merged 9 commits into from Aug 2, 2022
Merged

feat(sdk): add Bedrock support to SDK #3086

merged 9 commits into from Aug 2, 2022

Conversation

smartcontracts
Copy link
Contributor

@smartcontracts smartcontracts commented Jul 24, 2022 •
edited

Description
Updates the SDK to add support for Bedrock. Includes a minor fix to the
build pipeline for the contracts-bedrock package. Removes some utilities
that are now exported as part of core-utils.

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2022 •
edited

🦋 Changeset detected

Latest commit: 1389dd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@eth-optimism/sdk Minor
@eth-optimism/contracts-bedrock Patch
@eth-optimism/core-utils Patch
@eth-optimism/drippie-mon Patch
@eth-optimism/message-relayer Patch
@eth-optimism/common-ts Patch
@eth-optimism/contracts Patch
@eth-optimism/data-transport-layer Patch
@eth-optimism/replica-healthcheck Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-sdk Area: packages/sdk labels Jul 24, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 24, 2022

This PR changes implementation code, but doesn't include a changeset. Did you forget to add one?

@smartcontracts smartcontracts changed the title wip: add Bedrock support to SDK feat(sdk): add Bedrock support to SDK Jul 24, 2022
@github-actions github-actions bot added the A-integration Area: integration tests label Jul 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 25, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 25, 2022
@mergify mergify bot removed the conflict label Jul 25, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 28, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 28, 2022
@github-actions github-actions bot removed the A-integration Area: integration tests label Jul 28, 2022
@mergify mergify bot removed the conflict label Jul 28, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@mergify mergify bot added the conflict label Jul 29, 2022
@mergify mergify bot removed the conflict label Jul 29, 2022
@github-actions github-actions bot added A-pkg-core-utils Area: packages/core-utils 2-reviewers A-pkg-contracts-bedrock Area: packages/contracts-bedrock and removed A-pkg-contracts-bedrock Area: packages/contracts-bedrock 2-reviewers labels Jul 29, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 1, 2022

Hey @smartcontracts! This PR has merge conflicts. Please fix them before continuing review.

@tynes tynes marked this pull request as ready for review August 1, 2022 22:58
@tynes tynes self-requested a review August 1, 2022 23:40
roninjin10
roninjin10 approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@roninjin10 roninjin10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm couple of nits but non blocking

packages/sdk/src/adapters/eth-bridge.ts Show resolved Hide resolved
packages/sdk/src/adapters/eth-bridge.ts Show resolved Hide resolved
@mslipper
Copy link
Collaborator

mslipper commented Aug 2, 2022

This looks good to me. @tynes if you want another set of eyes please have them review, then remove mergify-ignore.

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2022

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify mergify bot removed the on-merge-train label Aug 2, 2022
@mergify
Copy link
Contributor

mergify bot commented Aug 2, 2022

This PR has been added to the merge queue, and will be merged soon.

@mergify mergify bot merged commit dac4a9f into develop Aug 2, 2022
@mergify mergify bot deleted the sc/sdk-bedrock-2 branch August 2, 2022 16:47
@mergify mergify bot removed the on-merge-train label Aug 2, 2022
@mslipper mslipper mentioned this pull request Aug 4, 2022
Merged
roninjin10 pushed a commit that referenced this pull request Aug 26, 2022
@smartcontracts @tynes
feat(sdk): add Bedrock support to SDK (#3086)
90fc287 
* core-utils: add bedrock types

* sdk: implement bedrock functionality

* tests: update for bedrock

* sdk: add hardhat deposit task

* circleci: run deposit task in ci

* tsconfig: cleanup

* contracts-bedrock: make commitment interval larger

* changeset: add

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
maurelian pushed a commit that referenced this pull request Sep 15, 2022
@smartcontracts @tynes @maurelian
feat(sdk): add Bedrock support to SDK (#3086)
09910f3 
* core-utils: add bedrock types

* sdk: implement bedrock functionality

* tests: update for bedrock

* sdk: add hardhat deposit task

* circleci: run deposit task in ci

* tsconfig: cleanup

* contracts-bedrock: make commitment interval larger

* changeset: add

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
sam-goldman pushed a commit that referenced this pull request Sep 15, 2022
@smartcontracts @tynes @sam-goldman
feat(sdk): add Bedrock support to SDK (#3086)
79807cb 
* core-utils: add bedrock types

* sdk: implement bedrock functionality

* tests: update for bedrock

* sdk: add hardhat deposit task

* circleci: run deposit task in ci

* tsconfig: cleanup

* contracts-bedrock: make commitment interval larger

* changeset: add

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
nitaliano pushed a commit that referenced this pull request May 20, 2024
@smartcontracts @tynes
feat(sdk): add Bedrock support to SDK (#3086)
8193c28 
* core-utils: add bedrock types

* sdk: implement bedrock functionality

* tests: update for bedrock

* sdk: add hardhat deposit task

* circleci: run deposit task in ci

* tsconfig: cleanup

* contracts-bedrock: make commitment interval larger

* changeset: add

Co-authored-by: Mark Tyneway <mark.tyneway@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mslipper mslipper mslipper approved these changes

@tynes tynes tynes approved these changes

@roninjin10 roninjin10 roninjin10 approved these changes

Assignees
No one assigned
Labels
A-pkg-contracts-bedrock Area: packages/contracts-bedrock A-pkg-core-utils Area: packages/core-utils A-pkg-sdk Area: packages/sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smartcontracts @mslipper @tynes @roninjin10