bedrock: Optional pprof servers #3136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This PR changes implementation code, but doesn't include a changeset. Did you forget to add one? |
mslipper
approved these changes
Jul 29, 2022
protolambda
approved these changes
Jul 29, 2022
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Merged
maurelian
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-batcher: Enable optional pprof server * op-proposer: Enable optional pprof server * op-node: Eanble optional pprof server Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
sam-goldman
pushed a commit
that referenced
this pull request
Sep 15, 2022
* op-batcher: Enable optional pprof server * op-proposer: Enable optional pprof server * op-node: Eanble optional pprof server Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds an optional pprof server to the op-node, op-batcher, & op-proposer.
The pprof server defaults to off & the address 0.0.0.0:6060. With docker compose,
it enables all of the pprof servers in the devnet with the following mapping:
Additional context
This only enables the default pprof servers. Further work is needed to run blocking
and mutex profiles. See https://pkg.go.dev/net/http/pprof
See the above details for a usage guide as well.
Metadata