[WIP] feat: ChugSplash v0 #469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Closing this until there's further activity! |
| ActionType _type, | ||
| string memory _target, | ||
| bytes memory _data, | ||
| uint256 _gasLimit |
There was a problem hiding this comment.
Consider adding a cancelDeployment function & requiring all calls pass
| /** | ||
| * @title ChugSplashDeployer | ||
| */ | ||
| contract ChugSplashDeployer { |
There was a problem hiding this comment.
Consider tradeoff of shutting down the system being encoded into the contract vs in the bundle
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOT READY FOR REVIEW
(I'm just using this as a way to keep track of my diff)
Description
Working on the various things necessary to get chugsplash off the ground.