You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@eth-optimism/sdk starting at 2.0.0 is assuming the FINALIZATION_PERIOD_SECOND is moved to L2OutputOracle, which is not the case for L2OutputOracle.version === '1.0.0'.
Version 1.0.0 of the L2OutputOracle is still deployed at Goerli, and all SDK consumers depending on the FINALIZATION_PERIOD_SECOND are broken right now (e.g. the fault-detector). This PR makes the sdk work with both 1.0.0 and the latest version of smart contracts.
Tests
No tests added. Manually ran yarn start in fault-detector to confirm this fixed the breakage.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
![semgrep-app[bot]](https://avatars.githubusercontent.com/in/60555?s=60&v=4){kind=small}
Description
@eth-optimism/sdk starting at 2.0.0 is assuming the
FINALIZATION_PERIOD_SECONDis moved to L2OutputOracle, which is not the case for L2OutputOracle.version === '1.0.0'.Version 1.0.0 of the L2OutputOracle is still deployed at Goerli, and all SDK consumers depending on the
FINALIZATION_PERIOD_SECONDare broken right now (e.g. the fault-detector). This PR makes the sdk work with both 1.0.0 and the latest version of smart contracts.Tests
No tests added. Manually ran
yarn startin fault-detector to confirm this fixed the breakage.Happy add a test if necessary.
Invariants
N/A since this PR does not change critical path.