Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(op-chain-ops): Compute local output root with op-node exported function #5533

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Apr 25, 2023

Description

This is a quick-fix discovered during a migration sherlock issue retro. The local output root in the op-chain-ops migrate command is computed manually using the Keccak256Hash function. This pr updates the code to use the exported ComputeL2OutputRoot from the op-node.

Metadata

@refcell refcell self-assigned this Apr 25, 2023
@refcell refcell requested a review from a team as a code owner April 25, 2023 20:30
@refcell refcell requested a review from tynes April 25, 2023 20:30
@changeset-bot
Copy link

changeset-bot bot commented Apr 25, 2023

⚠️ No Changeset found

Latest commit: a8f10c2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Apr 25, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit a8f10c2
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/64483afa54dee60008383f1e

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@tynes
Copy link
Contributor

tynes commented Apr 25, 2023

This originally did not use a function because there was a bug in the function, this script is not covered in CI but will remember if this script breaks this is what caused it

@OptimismBot OptimismBot merged commit 334a751 into develop Apr 25, 2023
@OptimismBot OptimismBot deleted the refcell/hashfix branch April 25, 2023 20:57
@mergify mergify bot removed the on-merge-train label Apr 25, 2023
@trianglesphere
Copy link
Contributor

This originally did not use a function because there was a bug in the function, this script is not covered in CI but will remember if this script breaks this is what caused it

IIRC there wasn't a bug in the function, but it was being called with the parameters in the wrong order. https://github.com/ethereum-optimism/optimism/pull/5114/files#diff-8f7bbce915ade563953fda055c7b5c424357da7cc240efd98a70bfce15abf4c1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants