op-batcher: Properly drain state on L2 reorgs #5536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Deploy Preview for opstack-docs canceled.
|
trianglesphere
force-pushed
the
jg/handle_l2_reorgs_cleanly
branch
2 times, most recently
from
e5f179d
to
0aff62e
Compare
trianglesphere
requested review from
mslipper and
ajsutton
and removed request for
mslipper
ajsutton
reviewed
Apr 26, 2023
When a L2 reorg occurs the batcher should close out the pending channel and submit everything that it has before clearing the channel builder. The reason for this is that even though it may be submitting incorrect data it should not leave dangling channels. After the pending state is drained it can begin tracking the new L2 chain.
trianglesphere
force-pushed
the
jg/handle_l2_reorgs_cleanly
branch
from
0aff62e
to
66f9e8e
Compare
|
This PR has been added to the merge queue, and will be merged soon. |
|
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When a L2 reorg occurs the batcher should close out the pending channel and submit everything that it has before clearing the channel builder. The reason for this is that even though it may be submitting incorrect data it should not leave dangling channels. After the pending state is drained it can begin tracking the new L2 chain.
Tests
Unfortunately the action tests are not suitable for testing this because they have rewritten the batcher. It might be possible in op-e2e, but I don't see an easy way to trigger a L2 reorg & also asserts that it does this flushing.
Metadata