-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts-bedrock): Gnosis Safe Tx Hash Validation #5553
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
packages/contracts-bedrock/scripts/upgrades/PostSherlockL2.s.sol
Outdated
Show resolved
Hide resolved
050f154
to
a18bd88
Compare
packages/contracts-bedrock/scripts/upgrades/PostSherlockL2.s.sol
Outdated
Show resolved
Hide resolved
f8a54b1
to
754bba4
Compare
I'd like to see what this looks like rebased on #5555 |
Hey @refcell! This PR has merge conflicts. Please fix them before continuing review. |
b44bcf8
to
2601957
Compare
b79cb0d
to
b78837a
Compare
e376bc7
to
245b999
Compare
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
Description
This introduces a
SafeBuilder
function to compute the gnosis safe tx hash for given safe and proxy admin addresses. It is wrapped by the downstream childPostSherlock.s.sol
andPostSherlockL2.s.sol
scripts.Can be run using
forge script --sig
as shown below.NOTE: Alchemy keys need to be supplied to the following commands.
Metadata