Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts-bedrock): Gnosis Safe Tx Hash Validation #5553

Merged
merged 2 commits into from
May 4, 2023

Conversation

refcell
Copy link
Contributor

@refcell refcell commented Apr 27, 2023

Description

This introduces a SafeBuilder function to compute the gnosis safe tx hash for given safe and proxy admin addresses. It is wrapped by the downstream child PostSherlock.s.sol and PostSherlockL2.s.sol scripts.

Can be run using forge script --sig as shown below.

NOTE: Alchemy keys need to be supplied to the following commands.

forge script \
    --rpc-url https://opt-goerli.g.alchemy.com/v2/<API_KEY> \
    --sig "computeSafeTransactionHash(address,address)" \
    scripts/upgrades/PostSherlockL2.s.sol \
    <SAFE_ADDRESS> <PROXY_ADMIN_ADDRESS>
forge script \
    --rpc-url https://eth-goerli.g.alchemy.com/v2/<API_KEY> \
    --sig "computeSafeTransactionHash(address,address)" \
    scripts/upgrades/PostSherlock.s.sol \
    <SAFE_ADDRESS> <PROXY_ADMIN_ADDRESS>

Metadata

@refcell refcell requested a review from a team as a code owner April 27, 2023 19:31
@refcell refcell requested a review from tynes April 27, 2023 19:31
@refcell refcell self-assigned this Apr 27, 2023
@changeset-bot
Copy link

changeset-bot bot commented Apr 27, 2023

⚠️ No Changeset found

Latest commit: 26f8c82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@refcell refcell requested a review from clabby April 27, 2023 19:31
@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 26f8c82
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/6453af06145d170008ab0262

@refcell refcell force-pushed the refcell/verifyscript branch 2 times, most recently from 050f154 to a18bd88 Compare April 28, 2023 15:02
@refcell refcell requested a review from tynes April 28, 2023 15:03
@tynes
Copy link
Contributor

tynes commented May 1, 2023

I'd like to see what this looks like rebased on #5555

@mergify
Copy link
Contributor

mergify bot commented May 1, 2023

Hey @refcell! This PR has merge conflicts. Please fix them before continuing review.

@OptimismBot OptimismBot merged commit 2389d44 into develop May 4, 2023
@OptimismBot OptimismBot deleted the refcell/verifyscript branch May 4, 2023 13:27
@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants