-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts-periphery): create Faucet contract #5595
Conversation
|
✅ Deploy Preview for opstack-docs canceled.
|
packages/contracts-periphery/contracts/universal/faucet/Faucet.sol
Outdated
Show resolved
Hide resolved
packages/contracts-periphery/contracts/universal/faucet/Faucet.sol
Outdated
Show resolved
Hide resolved
packages/contracts-periphery/contracts/universal/faucet/Faucet.sol
Outdated
Show resolved
Hide resolved
packages/contracts-periphery/contracts/universal/faucet/Faucet.sol
Outdated
Show resolved
Hide resolved
packages/contracts-periphery/contracts/universal/faucet/Faucet.sol
Outdated
Show resolved
Hide resolved
Semgrep found 1
Detected 'Fprintf' or similar writing to 'http.ResponseWriter'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package to render data to users. Created by no-fprintf-to-responsewriter. |
packages/contracts-periphery/contracts/universal/faucet/authmodules/AdminFaucetAuthModule.sol
Outdated
Show resolved
Hide resolved
packages/contracts-periphery/contracts/universal/faucet/Faucet.sol
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. We should put like 1k Goerli ETH into this contract and tell people they can keep the Goerli ETH if they break the contract.
packages/contracts-periphery/contracts/universal/faucet/authmodules/AdminFaucetAuthModule.sol
Outdated
Show resolved
Hide resolved
This PR has been added to the merge queue, and will be merged soon. |
This PR is next in line to be merged, and will be merged as soon as checks pass. |
1 similar comment
This PR is next in line to be merged, and will be merged as soon as checks pass. |
context & discussion
https://www.notion.so/oplabs/Superchain-faucet-backend-changes-ce42ce8e9f3b4725a41b696a822db4af?pvs=4
This contract will be used for distributing testnet funds from the Superchain faucet
Added Faucet contract
Added tests