Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts-periphery): create Faucet contract #5595

Merged
merged 14 commits into from
May 11, 2023

Conversation

tremarkley
Copy link
Contributor

context & discussion
https://www.notion.so/oplabs/Superchain-faucet-backend-changes-ce42ce8e9f3b4725a41b696a822db4af?pvs=4

This contract will be used for distributing testnet funds from the Superchain faucet

Added Faucet contract
Added tests

@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

⚠️ No Changeset found

Latest commit: b29868e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 3, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit b29868e
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645d14ce99a14600082c803a

@tremarkley tremarkley changed the title feat(contracts-periphery): create OptimistInviter contract feat(contracts-periphery): create Faucet contract May 4, 2023
@semgrep-app
Copy link

semgrep-app bot commented May 5, 2023

Semgrep found 1 no-fprintf-to-responsewriter finding:

  • proxyd/tools/mockserver/handler/handler.go: L76

Detected 'Fprintf' or similar writing to 'http.ResponseWriter'. This bypasses HTML escaping that prevents cross-site scripting vulnerabilities. Instead, use the 'html/template' package to render data to users.

Created by no-fprintf-to-responsewriter.

@tremarkley tremarkley marked this pull request as ready for review May 8, 2023 19:12
@tremarkley tremarkley requested a review from a team as a code owner May 8, 2023 19:12
Copy link
Contributor

@smartcontracts smartcontracts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should put like 1k Goerli ETH into this contract and tell people they can keep the Goerli ETH if they break the contract.

@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented May 11, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit a5a5529 into develop May 11, 2023
8 of 9 checks passed
@OptimismBot OptimismBot deleted the harry/faucet-contracts branch May 11, 2023 16:32
@mergify mergify bot removed the on-merge-train label May 11, 2023
trianglesphere added a commit that referenced this pull request May 17, 2023
…contracts"

This reverts commit a5a5529, reversing
changes made to 45fa82e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants