Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-program: Allow new named chains to be added without the op-geth config #5596

Merged
merged 2 commits into from
May 4, 2023

Conversation

ajsutton
Copy link
Contributor

@ajsutton ajsutton commented May 3, 2023

Description

Allow new named chains to be added without the op-geth config required by the fault proof program.

Simplifies the bedrock migration and the new mainnet config can be added afterwards.

Metadata

https://linear.app/optimism/issue/CLI-3936/add-mainnet-chain-config-to-fpp logged to add the config post-migration and re-enable the test since newly created chains won't have the complication of migration so should just be added immediately.

…nfig

Simplifies the bedrock migration and the new mainnet config can be added afterwards.
@ajsutton ajsutton requested a review from a team as a code owner May 3, 2023 23:56
@ajsutton ajsutton requested a review from Inphi May 3, 2023 23:56
@changeset-bot
Copy link

changeset-bot bot commented May 3, 2023

⚠️ No Changeset found

Latest commit: 874e057

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented May 4, 2023

Deploy Preview for opstack-docs canceled.

Name Link
🔨 Latest commit 874e057
🔍 Latest deploy log https://app.netlify.com/sites/opstack-docs/deploys/645328c1b75d7f0008748546

Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR has been added to the merge queue, and will be merged soon.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@mergify
Copy link
Contributor

mergify bot commented May 4, 2023

This PR is next in line to be merged, and will be merged as soon as checks pass.

@OptimismBot OptimismBot merged commit b9ca24e into develop May 4, 2023
8 of 9 checks passed
@OptimismBot OptimismBot deleted the aj/fpp-allow-new-named-configs branch May 4, 2023 03:53
@mergify mergify bot removed the on-merge-train label May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants